Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 756ab9c

Browse filesBrowse files
mscdexrvagg
authored andcommitted
stream: be less eager with readable flag
As of 34b535f, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: #4125 PR-URL: #4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 458facd commit 756ab9c
Copy full SHA for 756ab9c

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎lib/_stream_readable.js‎

Copy file name to clipboardExpand all lines: lib/_stream_readable.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,6 @@ function onEofChunk(stream, state) {
385385
}
386386
}
387387
state.ended = true;
388-
stream.readable = false;
389388

390389
// emit 'readable' now to make sure it gets picked up.
391390
emitReadable(stream);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.