Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7551a8b

Browse filesBrowse files
rexagodaddaleax
authored andcommitted
http2: return this for Http2ServerRequest#setTimeout
Fixes: #33993 PR-URL: #33994 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 388d125 commit 7551a8b
Copy full SHA for 7551a8b

File tree

Expand file treeCollapse file tree

2 files changed

+6
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+6
-4
lines changed
Open diff view settings
Collapse file

‎lib/internal/http2/compat.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/compat.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -405,9 +405,9 @@ class Http2ServerRequest extends Readable {
405405
}
406406

407407
setTimeout(msecs, callback) {
408-
if (this[kState].closed)
409-
return;
410-
this[kStream].setTimeout(msecs, callback);
408+
if (!this[kState].closed)
409+
this[kStream].setTimeout(msecs, callback);
410+
return this;
411411
}
412412
}
413413

Collapse file

‎test/parallel/test-http2-compat-serverrequest-settimeout.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http2-compat-serverrequest-settimeout.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,17 @@
33
const common = require('../common');
44
if (!common.hasCrypto)
55
common.skip('missing crypto');
6+
const assert = require('assert');
67
const http2 = require('http2');
78

89
const msecs = common.platformTimeout(1);
910
const server = http2.createServer();
1011

1112
server.on('request', (req, res) => {
12-
req.setTimeout(msecs, common.mustCall(() => {
13+
const request = req.setTimeout(msecs, common.mustCall(() => {
1314
res.end();
1415
}));
16+
assert.strictEqual(request, req);
1517
req.on('timeout', common.mustCall());
1618
res.on('finish', common.mustCall(() => {
1719
req.setTimeout(msecs, common.mustNotCall());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.