Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 74f128a

Browse filesBrowse files
danbevMylesBorins
danbev
authored and
MylesBorins
committed
build: make benchmark/napi all prereq order-only
This commit makes the all prerequisites order-only to prevent this target's rules to be executed every time which is currently the case as the all target is a phony target and will be executed every time. PR-URL: #23951 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent d25e94b commit 74f128a
Copy full SHA for 74f128a

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,19 +308,19 @@ test-valgrind: all
308308
test-check-deopts: all
309309
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) --check-deopts parallel sequential
310310

311-
benchmark/napi/function_call/build/Release/binding.node: all \
311+
benchmark/napi/function_call/build/Release/binding.node: \
312312
benchmark/napi/function_call/napi_binding.c \
313313
benchmark/napi/function_call/binding.cc \
314-
benchmark/napi/function_call/binding.gyp
314+
benchmark/napi/function_call/binding.gyp | all
315315
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
316316
--python="$(PYTHON)" \
317317
--directory="$(shell pwd)/benchmark/napi/function_call" \
318318
--nodedir="$(shell pwd)"
319319

320-
benchmark/napi/function_args/build/Release/binding.node: all \
320+
benchmark/napi/function_args/build/Release/binding.node: \
321321
benchmark/napi/function_args/napi_binding.c \
322322
benchmark/napi/function_args/binding.cc \
323-
benchmark/napi/function_args/binding.gyp
323+
benchmark/napi/function_args/binding.gyp | all
324324
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
325325
--python="$(PYTHON)" \
326326
--directory="$(shell pwd)/benchmark/napi/function_args" \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.