Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 747f368

Browse filesBrowse files
richardlauruyadorno
authored andcommitted
test: avoid left behind child processes
Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: #46276 Fixes: nodejs/build#3154 Refs: #37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2b06d66 commit 747f368
Copy full SHA for 747f368

File tree

Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-3
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-child-process-exec-abortcontroller-promisified.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-exec-abortcontroller-promisified.js
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ const invalidArgTypeError = {
1010
name: 'TypeError'
1111
};
1212

13-
const waitCommand = common.isLinux ?
14-
'sleep 2m' :
15-
`${process.execPath} -e "setInterval(()=>{}, 99)"`;
13+
const waitCommand = common.isWindows ?
14+
`${process.execPath} -e "setInterval(()=>{}, 99)"` :
15+
'sleep 2m';
1616

1717
{
1818
const ac = new AbortController();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.