Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 745e1e6

Browse filesBrowse files
addaleaxBethGriggs
authored andcommitted
http2: remove unused nghttp2 error list
Remove a list of HTTP2 errors as well as `nghttp2_errname()` that converted an integer nghttp2 error code to a string representation. We already use `nghttp2_strerror()` for this, which is provided by nghttp2 returns a better error string anyway. Backport-PR-URL: #22850 PR-URL: #21827 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 32bfd7e commit 745e1e6
Copy full SHA for 745e1e6

File tree

Expand file treeCollapse file tree

1 file changed

+0
-52
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-52
lines changed
Open diff view settings
Collapse file

‎src/node_http2.h‎

Copy file name to clipboardExpand all lines: src/node_http2.h
-52Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -377,58 +377,6 @@ enum padding_strategy_type {
377377
PADDING_STRATEGY_CALLBACK
378378
};
379379

380-
// These are the error codes provided by the underlying nghttp2 implementation.
381-
#define NGHTTP2_ERROR_CODES(V) \
382-
V(NGHTTP2_ERR_INVALID_ARGUMENT) \
383-
V(NGHTTP2_ERR_BUFFER_ERROR) \
384-
V(NGHTTP2_ERR_UNSUPPORTED_VERSION) \
385-
V(NGHTTP2_ERR_WOULDBLOCK) \
386-
V(NGHTTP2_ERR_PROTO) \
387-
V(NGHTTP2_ERR_INVALID_FRAME) \
388-
V(NGHTTP2_ERR_EOF) \
389-
V(NGHTTP2_ERR_DEFERRED) \
390-
V(NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE) \
391-
V(NGHTTP2_ERR_STREAM_CLOSED) \
392-
V(NGHTTP2_ERR_STREAM_CLOSING) \
393-
V(NGHTTP2_ERR_STREAM_SHUT_WR) \
394-
V(NGHTTP2_ERR_INVALID_STREAM_ID) \
395-
V(NGHTTP2_ERR_INVALID_STREAM_STATE) \
396-
V(NGHTTP2_ERR_DEFERRED_DATA_EXIST) \
397-
V(NGHTTP2_ERR_START_STREAM_NOT_ALLOWED) \
398-
V(NGHTTP2_ERR_GOAWAY_ALREADY_SENT) \
399-
V(NGHTTP2_ERR_INVALID_HEADER_BLOCK) \
400-
V(NGHTTP2_ERR_INVALID_STATE) \
401-
V(NGHTTP2_ERR_TEMPORAL_CALLBACK_FAILURE) \
402-
V(NGHTTP2_ERR_FRAME_SIZE_ERROR) \
403-
V(NGHTTP2_ERR_HEADER_COMP) \
404-
V(NGHTTP2_ERR_FLOW_CONTROL) \
405-
V(NGHTTP2_ERR_INSUFF_BUFSIZE) \
406-
V(NGHTTP2_ERR_PAUSE) \
407-
V(NGHTTP2_ERR_TOO_MANY_INFLIGHT_SETTINGS) \
408-
V(NGHTTP2_ERR_PUSH_DISABLED) \
409-
V(NGHTTP2_ERR_DATA_EXIST) \
410-
V(NGHTTP2_ERR_SESSION_CLOSING) \
411-
V(NGHTTP2_ERR_HTTP_HEADER) \
412-
V(NGHTTP2_ERR_HTTP_MESSAGING) \
413-
V(NGHTTP2_ERR_REFUSED_STREAM) \
414-
V(NGHTTP2_ERR_INTERNAL) \
415-
V(NGHTTP2_ERR_CANCEL) \
416-
V(NGHTTP2_ERR_FATAL) \
417-
V(NGHTTP2_ERR_NOMEM) \
418-
V(NGHTTP2_ERR_CALLBACK_FAILURE) \
419-
V(NGHTTP2_ERR_BAD_CLIENT_MAGIC) \
420-
V(NGHTTP2_ERR_FLOODED)
421-
422-
const char* nghttp2_errname(int rv) {
423-
switch (rv) {
424-
#define V(code) case code: return #code;
425-
NGHTTP2_ERROR_CODES(V)
426-
#undef V
427-
default:
428-
return "NGHTTP2_UNKNOWN_ERROR";
429-
}
430-
}
431-
432380
enum session_state_flags {
433381
SESSION_STATE_NONE = 0x0,
434382
SESSION_STATE_HAS_SCOPE = 0x1,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.