Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 74341ba

Browse filesBrowse files
committed
tools: fix v8-update workflow
- Add a step that configures Git so the update script can create commits. - Use `peter-evans/create-pull-request` as it's more maintained and correctly handles commits that are created before it runs. Refs: https://github.com/peter-evans/create-pull-request PR-URL: #52957 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent a814e72 commit 74341ba
Copy full SHA for 74341ba

File tree

Expand file treeCollapse file tree

1 file changed

+9
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+9
-8
lines changed
Open diff view settings
Collapse file

‎.github/workflows/update-v8.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/update-v8.yml
+9-8Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,23 @@ jobs:
3535
node-version: ${{ env.NODE_VERSION }}
3636
- name: Install @node-core/utils
3737
run: npm install -g @node-core/utils
38+
- name: Setup Git config
39+
run: |
40+
git config --global user.name "Node.js GitHub Bot"
41+
git config --global user.email "github-bot@iojs.org"
3842
- name: Check and download new V8 version
3943
run: |
4044
./tools/dep_updaters/update-v8-patch.sh > temp-output
4145
cat temp-output
4246
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
4347
rm temp-output
44-
- uses: gr2m/create-or-update-pull-request-action@86ec1766034c8173518f61d2075cc2a173fb8c97 # v1.9.4
48+
- uses: peter-evans/create-pull-request@6d6857d36972b65feb161a90e484f2984215f83e # v6.0.5
4549
# Creates a PR or update the Action's existing PR, or
4650
# no-op if the base branch is already up-to-date.
47-
env:
48-
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
4951
with:
50-
author: Node.js GitHub Bot <github-bot@iojs.org>
51-
body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}.
52+
token: ${{ secrets.GH_USER_TOKEN }}
5253
branch: actions/update-v8-patch # Custom branch *just* for this Action.
53-
commit-message: 'deps: patch V8 to ${{ env.NEW_VERSION }}'
54-
labels: v8 engine
54+
delete-branch: true
5555
title: 'deps: patch V8 to ${{ env.NEW_VERSION }}'
56-
update-pull-request-title-and-body: true
56+
body: This is an automated patch update of V8 to ${{ env.NEW_VERSION }}.
57+
labels: v8 engine

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.