Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 7428651

Browse filesBrowse files
lukekarrysRafaelGSS
authored andcommitted
test: convert test-debugger-pid to async/await
PR-URL: #45179 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent a866e8c commit 7428651
Copy full SHA for 7428651

File tree

Expand file treeCollapse file tree

1 file changed

+21
-38
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+21
-38
lines changed
Open diff view settings
Collapse file

‎test/sequential/test-debugger-pid.js‎

Copy file name to clipboardExpand all lines: test/sequential/test-debugger-pid.js
+21-38Lines changed: 21 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -9,44 +9,27 @@ const startCLI = require('../common/debugger');
99
const assert = require('assert');
1010
const { spawn } = require('child_process');
1111

12-
13-
function launchTarget(...args) {
14-
const childProc = spawn(process.execPath, args);
15-
return Promise.resolve(childProc);
16-
}
17-
18-
{
19-
const script = fixtures.path('debugger', 'alive.js');
20-
let cli = null;
21-
let target = null;
22-
23-
function cleanup(error) {
24-
if (cli) {
25-
cli.quit();
26-
cli = null;
27-
}
28-
if (target) {
29-
target.kill();
30-
target = null;
31-
}
12+
const script = fixtures.path('debugger', 'alive.js');
13+
14+
const runTest = async () => {
15+
const target = spawn(process.execPath, [script]);
16+
const cli = startCLI(['-p', `${target.pid}`]);
17+
18+
try {
19+
await cli.waitForPrompt();
20+
await cli.command('sb("alive.js", 3)');
21+
await cli.waitFor(/break/);
22+
await cli.waitForPrompt();
23+
assert.match(
24+
cli.output,
25+
/> 3 {3}\+\+x;/,
26+
'marks the 3rd line');
27+
} catch (error) {
3228
assert.ifError(error);
29+
} finally {
30+
await cli.quit();
31+
target.kill();
3332
}
33+
};
3434

35-
return launchTarget(script)
36-
.then((childProc) => {
37-
target = childProc;
38-
cli = startCLI(['-p', `${target.pid}`]);
39-
return cli.waitForPrompt();
40-
})
41-
.then(() => cli.command('sb("alive.js", 3)'))
42-
.then(() => cli.waitFor(/break/))
43-
.then(() => cli.waitForPrompt())
44-
.then(() => {
45-
assert.match(
46-
cli.output,
47-
/> 3 {3}\+\+x;/,
48-
'marks the 3rd line');
49-
})
50-
.then(() => cleanup())
51-
.then(null, cleanup);
52-
}
35+
runTest().then(common.mustCall());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.