nodejs
diff --git a/Collapse file
‎lib/internal/abort_controller.js‎
Copy file name to clipboardExpand all lines: lib/internal/abort_controller.js
+3-16Lines changed: 3 additions & 16 deletions b/Collapse file
‎lib/internal/abort_controller.js‎
Copy file name to clipboardExpand all lines: lib/internal/abort_controller.js
+3-16Lines changed: 3 additions & 16 deletions
diff --git a/Collapse file
‎test/parallel/test-abortcontroller.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-abortcontroller.js
+3-3Lines changed: 3 additions & 3 deletions b/Collapse file
‎test/parallel/test-abortcontroller.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-abortcontroller.js
+3-3Lines changed: 3 additions & 3 deletions
@@ -292,34 +292,21 @@ function abortSignal(signal, reason) {
   signal.dispatchEvent(event);
 }
 
-// TODO(joyeecheung): use private fields and we'll get invalid access
-// validation from V8 instead of throwing ERR_INVALID_THIS ourselves.
-const kSignal = Symbol('signal');
-
-function validateAbortController(obj) {
-  if (obj?.[kSignal] === undefined)
-    throw new ERR_INVALID_THIS('AbortController');
-}
-
 class AbortController {
-  constructor() {
-    this[kSignal] = createAbortSignal();
-  }
+  #signal = createAbortSignal();
 
   /**
    * @type {AbortSignal}
    */
   get signal() {
-    validateAbortController(this);
-    return this[kSignal];
+    return this.#signal;
   }
 
   /**
    * @param {any} reason
    */
   abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
-    validateAbortController(this);
-    abortSignal(this[kSignal], reason);
+    abortSignal(this.#signal, reason);
   }
 
   [customInspectSymbol](depth, options) {
 
@@ -108,11 +108,11 @@ const { setTimeout: sleep } = require('timers/promises');
   for (const badController of badAbortControllers) {
     throws(
       () => acSignalGet.call(badController),
-      { code: 'ERR_INVALID_THIS', name: 'TypeError' }
+      { name: 'TypeError' }
     );
     throws(
       () => acAbort.call(badController),
-      { code: 'ERR_INVALID_THIS', name: 'TypeError' }
+      { name: 'TypeError' }
     );
   }
 }
@@ -139,7 +139,7 @@ const { setTimeout: sleep } = require('timers/promises');
   for (const badSignal of badAbortSignals) {
     throws(
       () => signalAbortedGet.call(badSignal),
-      { code: 'ERR_INVALID_THIS', name: 'TypeError' }
+      { name: 'TypeError' }
     );
   }
 }
Original file line number	Diff line number	Diff line change
`@@ -108,11 +108,11 @@ const { setTimeout: sleep } = require('timers/promises');`
`108`	`108`	`for (const badController of badAbortControllers) {`
`109`	`109`	`throws(`
`110`	`110`	`() => acSignalGet.call(badController),`
`111`		`- { code: 'ERR_INVALID_THIS', name: 'TypeError' }`
	`111`	`+ { name: 'TypeError' }`
`112`	`112`	`);`
`113`	`113`	`throws(`
`114`	`114`	`() => acAbort.call(badController),`
`115`		`- { code: 'ERR_INVALID_THIS', name: 'TypeError' }`
	`115`	`+ { name: 'TypeError' }`
`116`	`116`	`);`
`117`	`117`	`}`
`118`	`118`	`}`
`@@ -139,7 +139,7 @@ const { setTimeout: sleep } = require('timers/promises');`
`139`	`139`	`for (const badSignal of badAbortSignals) {`
`140`	`140`	`throws(`
`141`	`141`	`() => signalAbortedGet.call(badSignal),`
`142`		`- { code: 'ERR_INVALID_THIS', name: 'TypeError' }`
	`142`	`+ { name: 'TypeError' }`
`143`	`143`	`);`
`144`	`144`	`}`
`145`	`145`	`}`