Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 72e4e43

Browse filesBrowse files
bnoordhuisevanlucas
authored andcommitted
test: rebuild add-ons when their sources change
The prerequisite for rebuilding was on the binding.gyp file but the actual sources. PR-URL: #7262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent 8e14f76 commit 72e4e43
Copy full SHA for 72e4e43

File tree

Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-1
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+5-1Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,15 @@ ADDONS_BINDING_GYPS := \
143143
$(filter-out test/addons/??_*/binding.gyp, \
144144
$(wildcard test/addons/*/binding.gyp))
145145

146+
ADDONS_BINDING_SOURCES := \
147+
$(filter-out test/addons/??_*/*.cc, $(wildcard test/addons/*/*.cc)) \
148+
$(filter-out test/addons/??_*/*.h, $(wildcard test/addons/*/*.h)) \
149+
146150
# Implicitly depends on $(NODE_EXE), see the build-addons rule for rationale.
147151
# Depends on node-gyp package.json so that build-addons is (re)executed when
148152
# node-gyp is updated as part of an npm update.
149153
test/addons/.buildstamp: deps/npm/node_modules/node-gyp/package.json \
150-
$(ADDONS_BINDING_GYPS) \
154+
$(ADDONS_BINDING_GYPS) $(ADDONS_BINDING_SOURCES) \
151155
deps/uv/include/*.h deps/v8/include/*.h \
152156
src/node.h src/node_buffer.h src/node_object_wrap.h \
153157
test/addons/.docbuildstamp

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.