Commit 720a2a6
test: move --cpu-prof tests to sequential
The tests still fail after being split into multiple files,
(2 out of 30 runs in roughly 48 hours) and the causes are missing
target frames in the samples. This patch moves them to sequential
to observe if the flakiness can be fixed when the tests are
run on a system with less load.
If the flake ever shows up again even after the tests are moved
to sequential, we should consider make the test conditions more
lenient - that is, we would only assert that there are *some* frames
in the generated CPU profile but do not look for the target
function there.
PR-URL: #28210
Refs: #27611
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 44b0e13 commit 720a2a6Copy full SHA for 720a2a6
File tree
Expand file treeCollapse file tree
11 files changed
+0
-0
lines changedOpen diff view settings
Filter options
- test/sequential
Expand file treeCollapse file tree
11 files changed
+0
-0
lines changedOpen diff view settings
File renamed without changes.
Collapse file
…t/parallel/test-cpu-prof-dir-absolute.js …sequential/test-cpu-prof-dir-absolute.jstest/parallel/test-cpu-prof-dir-absolute.js renamed to test/sequential/test-cpu-prof-dir-absolute.js test/parallel/test-cpu-prof-dir-absolute.js renamed to test/sequential/test-cpu-prof-dir-absolute.js
Copy file name to clipboardFile renamed without changes.
Collapse file
…t/parallel/test-cpu-prof-dir-and-name.js …sequential/test-cpu-prof-dir-and-name.jstest/parallel/test-cpu-prof-dir-and-name.js renamed to test/sequential/test-cpu-prof-dir-and-name.js test/parallel/test-cpu-prof-dir-and-name.js renamed to test/sequential/test-cpu-prof-dir-and-name.js
Copy file name to clipboardFile renamed without changes.
Collapse file
…t/parallel/test-cpu-prof-dir-relative.js …sequential/test-cpu-prof-dir-relative.jstest/parallel/test-cpu-prof-dir-relative.js renamed to test/sequential/test-cpu-prof-dir-relative.js test/parallel/test-cpu-prof-dir-relative.js renamed to test/sequential/test-cpu-prof-dir-relative.js
Copy file name to clipboardFile renamed without changes.
Collapse file
test/parallel/test-cpu-prof-dir-worker.js …t/sequential/test-cpu-prof-dir-worker.jstest/parallel/test-cpu-prof-dir-worker.js renamed to test/sequential/test-cpu-prof-dir-worker.js test/parallel/test-cpu-prof-dir-worker.js renamed to test/sequential/test-cpu-prof-dir-worker.js
Copy file name to clipboardFile renamed without changes.
File renamed without changes.
Collapse file
test/parallel/test-cpu-prof-exit.js test/sequential/test-cpu-prof-exit.jstest/parallel/test-cpu-prof-exit.js renamed to test/sequential/test-cpu-prof-exit.js
Copy file name to clipboardFile renamed without changes.
Collapse file
…arallel/test-cpu-prof-invalid-options.js …uential/test-cpu-prof-invalid-options.jstest/parallel/test-cpu-prof-invalid-options.js renamed to test/sequential/test-cpu-prof-invalid-options.js test/parallel/test-cpu-prof-invalid-options.js renamed to test/sequential/test-cpu-prof-invalid-options.js
Copy file name to clipboardFile renamed without changes.
Collapse file
test/parallel/test-cpu-prof-kill.js test/sequential/test-cpu-prof-kill.jstest/parallel/test-cpu-prof-kill.js renamed to test/sequential/test-cpu-prof-kill.js
Copy file name to clipboardFile renamed without changes.
Collapse file
test/parallel/test-cpu-prof-name.js test/sequential/test-cpu-prof-name.jstest/parallel/test-cpu-prof-name.js renamed to test/sequential/test-cpu-prof-name.js
Copy file name to clipboardFile renamed without changes.
0 commit comments