Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 71cf558

Browse filesBrowse files
Trotttargos
authored andcommitted
doc: remove "note that" from CPP_STYLE_GUIDE.md
Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 3d6ae65 commit 71cf558
Copy full SHA for 71cf558

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎CPP_STYLE_GUIDE.md‎

Copy file name to clipboardExpand all lines: CPP_STYLE_GUIDE.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ When there is a need to throw errors from a C++ binding method, try to
326326
return the data necessary for constructing the errors to JavaScript,
327327
then construct and throw the errors [using `lib/internal/errors.js`][errors].
328328

329-
Note that in general, type-checks on arguments should be done in JavaScript
329+
In general, type-checks on arguments should be done in JavaScript
330330
before the arguments are passed into C++. Then in the C++ binding, simply using
331331
`CHECK` assertions to guard against invalid arguments should be enough.
332332

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.