Commit 7134d49
child_process: clean event listener correctly
I was working on AbortSignal for spawn and noticed there is a leak in
the current code for AbortSignal support in child_process since it
removes the wrong listener. I used the new signal as argument feature
to make removing the listener easier and added a test.
PR-URL: #36424
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 63091f8 commit 7134d49Copy full SHA for 7134d49
File tree
Expand file treeCollapse file tree
2 files changed
+15
-5
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+15
-5
lines changedOpen diff view settings
Collapse file
+4-5Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
378 | 378 | |
379 | 379 | |
380 | 380 | |
| 381 | + |
381 | 382 | |
382 | | - |
| 383 | + |
383 | 384 | |
384 | | - |
385 | 385 | |
386 | | - |
387 | | - |
388 | | - |
| 386 | + |
| 387 | + |
389 | 388 | |
390 | 389 | |
391 | 390 | |
|
Collapse file
test/parallel/test-child-process-execfile.js
Copy file name to clipboardExpand all lines: test/parallel/test-child-process-execfile.js+11Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
3 | 3 | |
4 | 4 | |
5 | 5 | |
| 6 | + |
6 | 7 | |
7 | 8 | |
8 | 9 | |
| ||
68 | 69 | |
69 | 70 | |
70 | 71 | |
| 72 | + |
| 73 | + |
| 74 | + |
| 75 | + |
| 76 | + |
71 | 77 | |
| 78 | + |
| 79 | + |
| 80 | + |
| 81 | + |
| 82 | + |
72 | 83 | |
0 commit comments