Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6f80e30

Browse filesBrowse files
bzoztargos
authored andcommitted
build: build addons in parallel on Windows
Port #21155 to vcbuild.bat PR-URL: #21403 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 5a71e79 commit 6f80e30
Copy full SHA for 6f80e30

File tree

Expand file treeCollapse file tree

1 file changed

+5
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-7
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+5-7Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -448,13 +448,11 @@ for /d %%F in (test\addons\??_*) do (
448448
"%node_exe%" tools\doc\addon-verify.js
449449
if %errorlevel% neq 0 exit /b %errorlevel%
450450
:: building addons
451-
setlocal EnableDelayedExpansion
452-
for /d %%F in (test\addons\*) do (
453-
%node_gyp_exe% rebuild ^
454-
--directory="%%F" ^
455-
--nodedir="%cd%"
456-
if !errorlevel! neq 0 exit /b !errorlevel!
457-
)
451+
setlocal
452+
set npm_config_nodedir=%~dp0
453+
"%node_exe%" "%~dp0tools\build-addons.js" "%~dp0deps\npm\node_modules\node-gyp\bin\node-gyp.js" "%~dp0test\addons"
454+
if errorlevel 1 exit /b 1
455+
endlocal
458456

459457
:build-addons-napi
460458
if not defined build_addons_napi goto run-tests

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.