Commit 6f7b561
dns: update lookupService() first arg name
The first argument to lookupService() should be an IP address,
and is named "address" in the documentation. This commit updates
the code to match the documentation and provide less confusing
errors.
PR-URL: #29040
Fixes: #29039
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent e3b1243 commit 6f7b561Copy full SHA for 6f7b561
File tree
Expand file treeCollapse file tree
3 files changed
+18
-19
lines changedOpen diff view settings
Filter options
- lib
- internal/dns
- test/parallel
Expand file treeCollapse file tree
3 files changed
+18
-19
lines changedOpen diff view settings
Collapse file
+7-8Lines changed: 7 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
164 | 164 | |
165 | 165 | |
166 | 166 | |
167 | | - |
168 | | - |
| 167 | + |
169 | 168 | |
170 | | - |
| 169 | + |
171 | 170 | |
172 | | - |
173 | | - |
| 171 | + |
| 172 | + |
174 | 173 | |
175 | 174 | |
176 | 175 | |
| ||
182 | 181 | |
183 | 182 | |
184 | 183 | |
185 | | - |
| 184 | + |
186 | 185 | |
187 | 186 | |
188 | 187 | |
189 | | - |
190 | | - |
| 188 | + |
| 189 | + |
191 | 190 | |
192 | 191 | |
193 | 192 | |
|
Collapse file
lib/internal/dns/promises.js
Copy file name to clipboardExpand all lines: lib/internal/dns/promises.js+5-5Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
151 | 151 | |
152 | 152 | |
153 | 153 | |
154 | | - |
| 154 | + |
155 | 155 | |
156 | | - |
| 156 | + |
157 | 157 | |
158 | | - |
159 | | - |
| 158 | + |
| 159 | + |
160 | 160 | |
161 | 161 | |
162 | 162 | |
163 | 163 | |
164 | | - |
| 164 | + |
165 | 165 | |
166 | 166 | |
167 | 167 | |
|
Collapse file
+6-6Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
265 | 265 | |
266 | 266 | |
267 | 267 | |
268 | | - |
| 268 | + |
269 | 269 | |
270 | 270 | |
271 | 271 | |
272 | 272 | |
273 | | - |
| 273 | + |
274 | 274 | |
275 | 275 | |
276 | 276 | |
277 | 277 | |
278 | | - |
| 278 | + |
279 | 279 | |
280 | 280 | |
281 | 281 | |
282 | | - |
| 282 | + |
283 | 283 | |
284 | 284 | |
285 | 285 | |
286 | | - |
| 286 | + |
287 | 287 | |
288 | 288 | |
289 | 289 | |
290 | | - |
| 290 | + |
291 | 291 | |
292 | 292 | |
293 | 293 | |
|
0 commit comments