Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6f61407

Browse filesBrowse files
codebyteretargos
authored andcommitted
src: make debug_options getters public
This simplifies requires for those using DebugOptions, since debug_options was defined in src/node_options-inl.h and thus embedders would need to require an extra file to do what could trivially be consolidated into one. PR-URL: #30494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>
1 parent f76f143 commit 6f61407
Copy full SHA for 6f61407

File tree

Expand file treeCollapse file tree

2 files changed

+3
-10
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-10
lines changed
Open diff view settings
Collapse file

‎src/node_options-inl.h‎

Copy file name to clipboardExpand all lines: src/node_options-inl.h
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@ PerIsolateOptions* PerProcessOptions::get_per_isolate_options() {
1313
return per_isolate.get();
1414
}
1515

16-
DebugOptions* EnvironmentOptions::get_debug_options() {
17-
return &debug_options_;
18-
}
19-
20-
const DebugOptions& EnvironmentOptions::debug_options() const {
21-
return debug_options_;
22-
}
23-
2416
EnvironmentOptions* PerIsolateOptions::get_per_env_options() {
2517
return per_env.get();
2618
}
Collapse file

‎src/node_options.h‎

Copy file name to clipboardExpand all lines: src/node_options.h
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,9 @@ class EnvironmentOptions : public Options {
170170

171171
std::vector<std::string> user_argv;
172172

173-
inline DebugOptions* get_debug_options();
174-
inline const DebugOptions& debug_options() const;
173+
inline DebugOptions* get_debug_options() { return &debug_options_; }
174+
inline const DebugOptions& debug_options() const { return debug_options_; }
175+
175176
void CheckOptions(std::vector<std::string>* errors) override;
176177

177178
private:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.