Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6db76da

Browse filesBrowse files
amarzaveryMylesBorins
authored andcommitted
test: refactor test-cluster-send-handle-twice.js
- `var` --> `const` as applicable - `assert.equal` --> `assert.strictEqual` - `assert(false, ..)` --> `common.fail()` - `common.mustCall` for functions that need to be called exactly once - modified an `assert(!signal, 'Worker exited by a signal');` call to `assert.strictEqual(signal, null);` call as that made more sense PR-URL: #10049 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 19b314e commit 6db76da
Copy full SHA for 6db76da

File tree

Expand file treeCollapse file tree

1 file changed

+14
-14
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+14
-14
lines changed
Open diff view settings
Collapse file
+14-14Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,36 @@
11
'use strict';
22
// Testing to send an handle twice to the parent process.
33

4-
var common = require('../common');
5-
var assert = require('assert');
6-
var cluster = require('cluster');
7-
var net = require('net');
4+
const common = require('../common');
5+
const assert = require('assert');
6+
const cluster = require('cluster');
7+
const net = require('net');
88

9-
var workers = {
9+
const workers = {
1010
toStart: 1
1111
};
1212

1313
if (cluster.isMaster) {
14-
for (var i = 0; i < workers.toStart; ++i) {
15-
var worker = cluster.fork();
16-
worker.on('exit', function(code, signal) {
14+
for (let i = 0; i < workers.toStart; ++i) {
15+
const worker = cluster.fork();
16+
worker.on('exit', common.mustCall(function(code, signal) {
1717
assert.strictEqual(code, 0, 'Worker exited with an error code');
18-
assert(!signal, 'Worker exited by a signal');
19-
});
18+
assert.strictEqual(signal, null, 'Worker exited by a signal');
19+
}));
2020
}
2121
} else {
22-
var server = net.createServer(function(socket) {
22+
const server = net.createServer(function(socket) {
2323
process.send('send-handle-1', socket);
2424
process.send('send-handle-2', socket);
2525
});
2626

2727
server.listen(common.PORT, function() {
28-
var client = net.connect({ host: 'localhost', port: common.PORT });
29-
client.on('close', function() { cluster.worker.disconnect(); });
28+
const client = net.connect({ host: 'localhost', port: common.PORT });
29+
client.on('close', common.mustCall(() => { cluster.worker.disconnect(); }));
3030
setTimeout(function() { client.end(); }, 50);
3131
}).on('error', function(e) {
3232
console.error(e);
33-
assert(false, 'server.listen failed');
33+
common.fail('server.listen failed');
3434
cluster.worker.disconnect();
3535
});
3636
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.