Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6da4aa3

Browse filesBrowse files
gabrielschulhofdanielleadams
gabrielschulhof
authored and
danielleadams
committed
test: give js-native-api tests consistent names
The convention for js-native-api/<test_name>: * <test_name>.c or <test_name>.cc has the entry point * The name of the target is <test_name> PR-URL: #38692 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent a47fd67 commit 6da4aa3
Copy full SHA for 6da4aa3

File tree

Expand file treeCollapse file tree

24 files changed

+24
-24
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

24 files changed

+24
-24
lines changed
Open diff view settings
Collapse file

‎…ative-api/2_function_arguments/binding.c‎ ‎…unction_arguments/2_function_arguments.c‎test/js-native-api/2_function_arguments/binding.c renamed to test/js-native-api/2_function_arguments/2_function_arguments.c test/js-native-api/2_function_arguments/binding.c renamed to test/js-native-api/2_function_arguments/2_function_arguments.c

Copy file name to clipboard
File renamed without changes.
Collapse file

‎test/js-native-api/2_function_arguments/binding.gyp‎

Copy file name to clipboardExpand all lines: test/js-native-api/2_function_arguments/binding.gyp
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "2_function_arguments",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"2_function_arguments.c"
88
]
99
}
1010
]
Collapse file

‎test/js-native-api/2_function_arguments/test.js‎

Copy file name to clipboard
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/2_function_arguments`);
55

66
assert.strictEqual(addon.add(3, 5), 8);
Collapse file

‎test/js-native-api/3_callbacks/binding.c‎ ‎…/js-native-api/3_callbacks/3_callbacks.c‎test/js-native-api/3_callbacks/binding.c renamed to test/js-native-api/3_callbacks/3_callbacks.c test/js-native-api/3_callbacks/binding.c renamed to test/js-native-api/3_callbacks/3_callbacks.c

Copy file name to clipboard
File renamed without changes.
Collapse file

‎test/js-native-api/3_callbacks/binding.gyp‎

Copy file name to clipboardExpand all lines: test/js-native-api/3_callbacks/binding.gyp
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "3_callbacks",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"3_callbacks.c"
88
]
99
}
1010
]
Collapse file

‎test/js-native-api/3_callbacks/test.js‎

Copy file name to clipboardExpand all lines: test/js-native-api/3_callbacks/test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/3_callbacks`);
55

66
addon.RunCallback(function(msg) {
77
assert.strictEqual(msg, 'hello world');
Collapse file

‎…js-native-api/4_object_factory/binding.c‎ ‎…-api/4_object_factory/4_object_factory.c‎test/js-native-api/4_object_factory/binding.c renamed to test/js-native-api/4_object_factory/4_object_factory.c test/js-native-api/4_object_factory/binding.c renamed to test/js-native-api/4_object_factory/4_object_factory.c

Copy file name to clipboard
File renamed without changes.
Collapse file

‎test/js-native-api/4_object_factory/binding.gyp‎

Copy file name to clipboardExpand all lines: test/js-native-api/4_object_factory/binding.gyp
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"targets": [
33
{
4-
"target_name": "binding",
4+
"target_name": "4_object_factory",
55
"sources": [
66
"../entry_point.c",
7-
"binding.c"
7+
"4_object_factory.c"
88
]
99
}
1010
]
Collapse file

‎test/js-native-api/4_object_factory/test.js‎

Copy file name to clipboardExpand all lines: test/js-native-api/4_object_factory/test.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use strict';
22
const common = require('../../common');
33
const assert = require('assert');
4-
const addon = require(`./build/${common.buildType}/binding`);
4+
const addon = require(`./build/${common.buildType}/4_object_factory`);
55

66
const obj1 = addon('hello');
77
const obj2 = addon('world');
Collapse file

‎…-native-api/5_function_factory/binding.c‎ ‎…/5_function_factory/5_function_factory.c‎test/js-native-api/5_function_factory/binding.c renamed to test/js-native-api/5_function_factory/5_function_factory.c test/js-native-api/5_function_factory/binding.c renamed to test/js-native-api/5_function_factory/5_function_factory.c

Copy file name to clipboard
File renamed without changes.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.