Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6d5ded5

Browse filesBrowse files
Johnny ReadingFishrock123
authored andcommitted
test: refactor test-domain
Use assert.strictEqual() instead of assert.equal(). PR-URL: #9890 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 318a2db commit 6d5ded5
Copy full SHA for 6d5ded5

File tree

Expand file treeCollapse file tree

1 file changed

+34
-33
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+34
-33
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-domain.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-domain.js
+34-33Lines changed: 34 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -31,67 +31,67 @@ d.on('error', function(er) {
3131

3232
switch (er_message) {
3333
case 'emitted':
34-
assert.equal(er.domain, d);
35-
assert.equal(er.domainEmitter, e);
36-
assert.equal(er.domainThrown, false);
34+
assert.strictEqual(er.domain, d);
35+
assert.strictEqual(er.domainEmitter, e);
36+
assert.strictEqual(er.domainThrown, false);
3737
break;
3838

3939
case 'bound':
4040
assert.ok(!er.domainEmitter);
41-
assert.equal(er.domain, d);
42-
assert.equal(er.domainBound, fn);
43-
assert.equal(er.domainThrown, false);
41+
assert.strictEqual(er.domain, d);
42+
assert.strictEqual(er.domainBound, fn);
43+
assert.strictEqual(er.domainThrown, false);
4444
break;
4545

4646
case 'thrown':
4747
assert.ok(!er.domainEmitter);
48-
assert.equal(er.domain, d);
49-
assert.equal(er.domainThrown, true);
48+
assert.strictEqual(er.domain, d);
49+
assert.strictEqual(er.domainThrown, true);
5050
break;
5151

5252
case "ENOENT: no such file or directory, open 'this file does not exist'":
53-
assert.equal(er.domain, d);
54-
assert.equal(er.domainThrown, false);
55-
assert.equal(typeof er.domainBound, 'function');
53+
assert.strictEqual(er.domain, d);
54+
assert.strictEqual(er.domainThrown, false);
55+
assert.strictEqual(typeof er.domainBound, 'function');
5656
assert.ok(!er.domainEmitter);
57-
assert.equal(er.code, 'ENOENT');
58-
assert.equal(er_path, 'this file does not exist');
59-
assert.equal(typeof er.errno, 'number');
57+
assert.strictEqual(er.code, 'ENOENT');
58+
assert.strictEqual(er_path, 'this file does not exist');
59+
assert.strictEqual(typeof er.errno, 'number');
6060
break;
6161

6262
case
6363
"ENOENT: no such file or directory, open 'stream for nonexistent file'":
64-
assert.equal(typeof er.errno, 'number');
65-
assert.equal(er.code, 'ENOENT');
66-
assert.equal(er_path, 'stream for nonexistent file');
67-
assert.equal(er.domain, d);
68-
assert.equal(er.domainEmitter, fst);
64+
assert.strictEqual(typeof er.errno, 'number');
65+
assert.strictEqual(er.code, 'ENOENT');
66+
assert.strictEqual(er_path, 'stream for nonexistent file');
67+
assert.strictEqual(er.domain, d);
68+
assert.strictEqual(er.domainEmitter, fst);
6969
assert.ok(!er.domainBound);
70-
assert.equal(er.domainThrown, false);
70+
assert.strictEqual(er.domainThrown, false);
7171
break;
7272

7373
case 'implicit':
74-
assert.equal(er.domainEmitter, implicit);
75-
assert.equal(er.domain, d);
76-
assert.equal(er.domainThrown, false);
74+
assert.strictEqual(er.domainEmitter, implicit);
75+
assert.strictEqual(er.domain, d);
76+
assert.strictEqual(er.domainThrown, false);
7777
assert.ok(!er.domainBound);
7878
break;
7979

8080
case 'implicit timer':
81-
assert.equal(er.domain, d);
82-
assert.equal(er.domainThrown, true);
81+
assert.strictEqual(er.domain, d);
82+
assert.strictEqual(er.domainThrown, true);
8383
assert.ok(!er.domainEmitter);
8484
assert.ok(!er.domainBound);
8585
break;
8686

8787
case 'Cannot read property \'isDirectory\' of undefined':
88-
assert.equal(er.domain, d);
88+
assert.strictEqual(er.domain, d);
8989
assert.ok(!er.domainEmitter);
9090
assert.ok(!er.domainBound);
9191
break;
9292

9393
case 'nextTick execution loop':
94-
assert.equal(er.domain, d);
94+
assert.strictEqual(er.domain, d);
9595
assert.ok(!er.domainEmitter);
9696
assert.ok(!er.domainBound);
9797
break;
@@ -107,7 +107,8 @@ d.on('error', function(er) {
107107

108108
process.on('exit', function() {
109109
console.error('exit', caught, expectCaught);
110-
assert.equal(caught, expectCaught, 'caught the expected number of errors');
110+
assert.strictEqual(caught, expectCaught,
111+
'caught the expected number of errors');
111112
console.log('ok');
112113
});
113114

@@ -172,7 +173,7 @@ expectCaught++;
172173

173174
// intercepted should never pass first argument to callback
174175
function fn2(data) {
175-
assert.equal(data, 'data', 'should not be null err argument');
176+
assert.strictEqual(data, 'data', 'should not be null err argument');
176177
}
177178

178179
bound = d.intercept(fn2);
@@ -181,8 +182,8 @@ bound(null, 'data');
181182
// intercepted should never pass first argument to callback
182183
// even if arguments length is more than 2.
183184
function fn3(data, data2) {
184-
assert.equal(data, 'data', 'should not be null err argument');
185-
assert.equal(data2, 'data2', 'should not be data argument');
185+
assert.strictEqual(data, 'data', 'should not be null err argument');
186+
assert.strictEqual(data2, 'data2', 'should not be data argument');
186187
}
187188

188189
bound = d.intercept(fn3);
@@ -225,14 +226,14 @@ expectCaught++;
225226
var result = d.run(function() {
226227
return 'return value';
227228
});
228-
assert.equal(result, 'return value');
229+
assert.strictEqual(result, 'return value');
229230

230231

231232
// check if the executed function take in count the applied parameters
232233
result = d.run(function(a, b) {
233234
return a + ' ' + b;
234235
}, 'return', 'value');
235-
assert.equal(result, 'return value');
236+
assert.strictEqual(result, 'return value');
236237

237238

238239
var fst = fs.createReadStream('stream for nonexistent file');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.