Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6c41f33

Browse filesBrowse files
Trotttargos
authored andcommitted
doc: wrap pull-requests.md at 80 characters
PR-URL: #21361 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b8213f1 commit 6c41f33
Copy full SHA for 6c41f33

File tree

Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-3
lines changed
Open diff view settings
Collapse file

‎doc/guides/contributing/pull-requests.md‎

Copy file name to clipboardExpand all lines: doc/guides/contributing/pull-requests.md
+4-3Lines changed: 4 additions & 3 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ notes about [commit squashing](#commit-squashing)).
137137
A good commit message should describe what changed and why.
138138

139139
1. The first line should:
140-
- contain a short description of the change (preferably 50 characters or less,
141-
and no more than 72 characters)
140+
- contain a short description of the change (preferably 50 characters or
141+
less, and no more than 72 characters)
142142
- be entirely in lowercase with the exception of proper nouns, acronyms, and
143143
the words that refer to code, like function/variable names
144144
- be prefixed with the name of the changed subsystem and start with an
@@ -456,7 +456,8 @@ Focus first on the most significant aspects of the change:
456456
1. Does this change make sense for Node.js?
457457
2. Does this change make Node.js better, even if only incrementally?
458458
3. Are there clear bugs or larger scale issues that need attending to?
459-
4. Is the commit message readable and correct? If it contains a breaking change is it clear enough?
459+
4. Is the commit message readable and correct? If it contains a breaking change
460+
is it clear enough?
460461

461462
When changes are necessary, *request* them, do not *demand* them, and do not
462463
assume that the submitter already knows how to add a test or run a benchmark.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.