nodejs
diff --git a/Collapse file
‎lib/internal/bootstrap_node.js‎
Copy file name to clipboardExpand all lines: lib/internal/bootstrap_node.js
+2-2Lines changed: 2 additions & 2 deletions b/Collapse file
‎lib/internal/bootstrap_node.js‎
Copy file name to clipboardExpand all lines: lib/internal/bootstrap_node.js
+2-2Lines changed: 2 additions & 2 deletions
diff --git a/Collapse file
‎test/fixtures/overwrite-config-preload-module.js‎
Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions b/Collapse file
‎test/fixtures/overwrite-config-preload-module.js‎
Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions
diff --git a/Collapse file
‎test/sequential/test-inspector-overwrite-config.js‎
Copy file name to clipboard
+41Lines changed: 41 additions & 0 deletions b/Collapse file
‎test/sequential/test-inspector-overwrite-config.js‎
Copy file name to clipboard
+41Lines changed: 41 additions & 0 deletions
@@ -327,10 +327,10 @@
   }
 
   function setupInspector(originalConsole, wrappedConsole, Module) {
-    const { addCommandLineAPI, consoleCall } = process.binding('inspector');
-    if (!consoleCall) {
+    if (!process.config.variables.v8_enable_inspector) {
       return;
     }
+    const { addCommandLineAPI, consoleCall } = process.binding('inspector');
     // Setup inspector command line API
     const { makeRequireFunction } = NativeModule.require('internal/module');
     const path = NativeModule.require('path');
 
@@ -0,0 +1,5 @@
+'use strict'
+const common = require('../common');
+common.skipIfInspectorDisabled();
+
+process.config = {};
@@ -0,0 +1,41 @@
+// Flags: --require ./test/fixtures/overwrite-config-preload-module.js
+'use strict';
+
+// This test ensures that overwriting a process configuration
+// value does not affect code in bootstrap_node.js. Specifically this tests
+// that the inspector console functions are bound even though
+// overwrite-config-preload-module.js overwrote the process.config variable.
+
+// We cannot do a check for the inspector because the configuration variables
+// were reset/removed by overwrite-config-preload-module.js.
+/* eslint-disable inspector-check */
+
+const common = require('../common');
+const assert = require('assert');
+const inspector = require('inspector');
+const msg = 'Test inspector logging';
+let asserted = false;
+
+async function testConsoleLog() {
+  const session = new inspector.Session();
+  session.connect();
+  session.on('inspectorNotification', (data) => {
+    if (data.method === 'Runtime.consoleAPICalled') {
+      assert.strictEqual(data.params.args.length, 1);
+      assert.strictEqual(data.params.args[0].value, msg);
+      asserted = true;
+    }
+  });
+  session.post('Runtime.enable');
+  console.log(msg);
+  session.disconnect();
+}
+
+common.crashOnUnhandledRejection();
+
+async function runTests() {
+  await testConsoleLog();
+  assert.ok(asserted, 'log statement did not reach the inspector');
+}
+
+runTests();
Original file line number	Diff line number	Diff line change
`@@ -327,10 +327,10 @@`
`327`	`327`	`}`
`328`	`328`
`329`	`329`	`function setupInspector(originalConsole, wrappedConsole, Module) {`
`330`		`- const { addCommandLineAPI, consoleCall } = process.binding('inspector');`
`331`		`- if (!consoleCall) {`
	`330`	`+ if (!process.config.variables.v8_enable_inspector) {`
`332`	`331`	`return;`
`333`	`332`	`}`
	`333`	`+ const { addCommandLineAPI, consoleCall } = process.binding('inspector');`
`334`	`334`	`// Setup inspector command line API`
`335`	`335`	`const { makeRequireFunction } = NativeModule.require('internal/module');`
`336`	`336`	`const path = NativeModule.require('path');`