Commit 6be4942
lib: move duplicate spliceOne into internal/util
lib/url.js and lib/events.js are using the same spliceOne function.
This change is to move it into the internal/util for avoiding duplicate
code.
PR-URL: #16221
Backport-PR-URL: #16433
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>1 parent 55ba1d4 commit 6be4942Copy full SHA for 6be4942
Expand file treeCollapse file tree
3 files changed
+15
-16
lines changedOpen diff view settings
Collapse file
+5-8Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
22 | 22 | |
23 | 23 | |
24 | 24 | |
| 25 | + |
25 | 26 | |
26 | 27 | |
27 | 28 | |
| ||
389 | 390 | |
390 | 391 | |
391 | 392 | |
392 | | - |
| 393 | + |
| 394 | + |
| 395 | + |
393 | 396 | |
| 397 | + |
394 | 398 | |
395 | 399 | |
396 | 400 | |
| ||
502 | 506 | |
503 | 507 | |
504 | 508 | |
505 | | - |
506 | | - |
507 | | - |
508 | | - |
509 | | - |
510 | | - |
511 | | - |
512 | 509 | |
513 | 510 | |
514 | 511 | |
|
Collapse file
+9-1Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
266 | 266 | |
267 | 267 | |
268 | 268 | |
| 269 | + |
| 270 | + |
| 271 | + |
| 272 | + |
| 273 | + |
| 274 | + |
| 275 | + |
269 | 276 | |
270 | 277 | |
271 | 278 | |
| ||
276 | 283 | |
277 | 284 | |
278 | 285 | |
| 286 | + |
279 | 287 | |
280 | 288 | |
281 | 289 | |
282 | | - |
| 290 | + |
283 | 291 | |
284 | 292 | |
285 | 293 | |
|
Collapse file
+1-7Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
25 | 25 | |
26 | 26 | |
27 | 27 | |
| 28 | + |
28 | 29 | |
29 | 30 | |
30 | 31 | |
| ||
948 | 949 | |
949 | 950 | |
950 | 951 | |
951 | | - |
952 | | - |
953 | | - |
954 | | - |
955 | | - |
956 | | - |
957 | | - |
958 | 952 | |
959 | 953 | |
960 | 954 | |
|
0 commit comments