Commit 6b74064
test: fix flaky test-http-dns-error
Under some conditions, the error received from getaddrinfo might
actually be EAGAIN, meaning the request should be retried. Allowing for
5 retries before erroring out.
Also replace one-off function with common.mustNotCall().
PR-URL: #16534
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent eb25252 commit 6b74064Copy full SHA for 6b74064
File tree
Expand file treeCollapse file tree
1 file changed
+23
-12
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+23
-12
lines changedOpen diff view settings
Collapse file
test/parallel/test-http-dns-error.js
Copy file name to clipboardExpand all lines: test/parallel/test-http-dns-error.js+23-12Lines changed: 23 additions & 12 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
30 | 30 | |
31 | 31 | |
32 | 32 | |
| 33 | + |
33 | 34 | |
34 | | - |
35 | | - |
36 | | - |
37 | | - |
38 | | - |
39 | | - |
| 35 | + |
40 | 36 | |
41 | 37 | |
42 | | - |
43 | | - |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
44 | 44 | |
45 | 45 | |
46 | 46 | |
| 47 | + |
47 | 48 | |
48 | | - |
| 49 | + |
| 50 | + |
49 | 51 | |
50 | 52 | |
51 | 53 | |
52 | | - |
53 | | - |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
| 59 | + |
54 | 60 | |
55 | 61 | |
56 | | - |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
57 | 68 | |
58 | 69 | |
59 | 70 | |
|
0 commit comments