Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6ae9bc8

Browse filesBrowse files
RafaelGSSdanielleadams
authored andcommitted
doc: add extra step for reporter pre-approval
As discussed in the #security-triagge (OpenJS channel). To avoid insufficient CVE fixes across Security Release, might make sense to request a reporter pre-approval. PR-URL: #44806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 8daceda commit 6ae9bc8
Copy full SHA for 6ae9bc8

File tree

Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-0
lines changed
Open diff view settings
Collapse file

‎doc/contributing/security-release-process.md‎

Copy file name to clipboardExpand all lines: doc/contributing/security-release-process.md
+6Lines changed: 6 additions & 0 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ The current security stewards are documented in the main Node.js
4444
the date in the slug so that it will move to the top of the blog list.)
4545
* (Consider using a [Vulnerability Score System](https://www.first.org/cvss/calculator/3.1)
4646
to identify severity of each report)
47+
* Share the patch with the reporter when applicable.
48+
It will increase the fix accuracy.
4749
* [ ] pre-release: _**LINK TO PR**_
4850
* [ ] post-release: _**LINK TO PR**_
4951
* List vulnerabilities in order of descending severity
@@ -66,6 +68,10 @@ The current security stewards are documented in the main Node.js
6668
* [ ] Check that all vulnerabilities are ready for release integration:
6769
* PRs against all affected release lines or cherry-pick clean
6870
* Approved
71+
* (optional) Approved by the reporter
72+
* Build and send the binary to the reporter according to its architecture
73+
and ask for a review. This step is important to avoid insufficient fixes
74+
between Security Releases.
6975
* Pass `make test`
7076
* Have CVEs
7177
* Make sure that dependent libraries have CVEs for their issues. We should

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.