Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6ae7d30

Browse filesBrowse files
ryzokukenMylesBorins
authored andcommitted
tools: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. Backport-PR-URL: #30109 PR-URL: #29694 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent 5bd6947 commit 6ae7d30
Copy full SHA for 6ae7d30

File tree

Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎deps/v8/src/compiler/js-heap-broker.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/compiler/js-heap-broker.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4115,6 +4115,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell,
41154115

41164116
GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind)
41174117
: ProcessedFeedback(kGlobalAccess, slot_kind),
4118+
cell_or_context_(base::nullopt),
41184119
index_and_immutable_(0 /* doesn't matter */) {
41194120
DCHECK(IsGlobalICKind(slot_kind));
41204121
}
Collapse file

‎deps/v8/src/interpreter/interpreter.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/interpreter/interpreter.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ Interpreter::NewSourcePositionCollectionJob(
280280
auto job = base::make_unique<InterpreterCompilationJob>(parse_info, literal,
281281
allocator, nullptr);
282282
job->compilation_info()->SetBytecodeArray(existing_bytecode);
283-
return job;
283+
return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) };
284284
}
285285

286286
void Interpreter::ForEachBytecode(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.