Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6ac52e3

Browse filesBrowse files
VoltrexKeyvadanielleadams
VoltrexKeyva
authored and
danielleadams
committed
doc: fix grammar in the collaborator guide
PR-URL: #47245 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
1 parent 1317577 commit 6ac52e3
Copy full SHA for 6ac52e3

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎doc/contributing/collaborator-guide.md‎

Copy file name to clipboardExpand all lines: doc/contributing/collaborator-guide.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ The TSC serves as the final arbiter where required.
509509
squashing only keeps one author.
510510
* The "Rebase and merge" method has no way of adding metadata to the commit.
511511
3. Make sure CI is complete and green. If the CI is not green, check for
512-
unreliable tests and infrastructure failures. If there are not corresponding
512+
unreliable tests and infrastructure failures. If there are no corresponding
513513
issues in the [node][unreliable tests] or
514514
[build](https://github.com/nodejs/build/issues) repositories, open new
515515
issues. Run a new CI any time someone pushes new code to the pull request.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.