Commit 6a4e99b
net,tls: pass a valid socket on
On the 'tlsClientError' event, the `tlsSocket` instance is passed as
`closed` status. Thus, users can't get information such as `remote
address`, `remoteFamily`, and so on.
This adds a flag to close a socket after emitting an `error` event.
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44021
Fixes: #43963
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>tlsClientError
1 parent 273c532 commit 6a4e99bCopy full SHA for 6a4e99b
File tree
Expand file treeCollapse file tree
3 files changed
+61
-7
lines changedOpen diff view settings
Filter options
- lib
- test/internet
Expand file treeCollapse file tree
3 files changed
+61
-7
lines changedOpen diff view settings
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
423 | 423 | |
424 | 424 | |
425 | 425 | |
| 426 | + |
| 427 | + |
| 428 | + |
| 429 | + |
426 | 430 | |
427 | 431 | |
428 | 432 | |
|
Collapse file
+26-7Lines changed: 26 additions & 7 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
102 | 102 | |
103 | 103 | |
104 | 104 | |
| 105 | + |
105 | 106 | |
106 | 107 | |
107 | 108 | |
| ||
284 | 285 | |
285 | 286 | |
286 | 287 | |
| 288 | + |
| 289 | + |
| 290 | + |
| 291 | + |
| 292 | + |
| 293 | + |
| 294 | + |
| 295 | + |
| 296 | + |
| 297 | + |
| 298 | + |
| 299 | + |
| 300 | + |
287 | 301 | |
288 | 302 | |
289 | 303 | |
| ||
332 | 346 | |
333 | 347 | |
334 | 348 | |
| 349 | + |
335 | 350 | |
336 | 351 | |
337 | 352 | |
| ||
751 | 766 | |
752 | 767 | |
753 | 768 | |
| 769 | + |
| 770 | + |
| 771 | + |
| 772 | + |
754 | 773 | |
755 | | - |
756 | | - |
757 | | - |
758 | | - |
| 774 | + |
| 775 | + |
| 776 | + |
| 777 | + |
| 778 | + |
| 779 | + |
| 780 | + |
759 | 781 | |
760 | | - |
761 | | - |
762 | | - |
763 | 782 | |
764 | 783 | |
765 | 784 | |
|
Collapse file
test/internet/test-https-issue-43963.js
Copy file name to clipboard+31Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
0 commit comments