Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6a113da

Browse filesBrowse files
addaleaxMylesBorins
authored andcommitted
test: rename and document tls test
Add a short description and one question to a TLS test. Also, rename it since the previous name might unintentionally evoke connotations to an internet meme that would generally not be considered appropriate in our context. PR-URL: #20820 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent 545a9d8 commit 6a113da
Copy full SHA for 6a113da

File tree

Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+5
-0
lines changed
Open diff view settings
Collapse file

‎…/parallel/test-tls-two-cas-one-string.js‎ ‎…allel/test-tls-multiple-cas-as-string.js‎test/parallel/test-tls-two-cas-one-string.js renamed to test/parallel/test-tls-multiple-cas-as-string.js test/parallel/test-tls-two-cas-one-string.js renamed to test/parallel/test-tls-multiple-cas-as-string.js

Copy file name to clipboardExpand all lines: test/parallel/test-tls-multiple-cas-as-string.js
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ const common = require('../common');
44
if (!common.hasCrypto)
55
common.skip('missing crypto');
66

7+
// Verify that multiple CA certificates can be provided, and that for
8+
// convenience that can also be in newline-separated strings.
9+
710
const tls = require('tls');
811
const fixtures = require('../common/fixtures');
912

@@ -30,6 +33,8 @@ function test(ca, next) {
3033
}
3134
}
3235

36+
// `ca1` is not actually necessary for the certificate validation -- maybe
37+
// the fixtures should be written in a way that requires it?
3338
const array = [ca1, ca2];
3439
const string = `${ca1}\n${ca2}`;
3540
test(array, common.mustCall(() => test(string)));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.