Commit 69ec9be
module: ignore resolution failures for inspect-brk
The resolution for the main entry point may fail when the resolution
requires a preloaded module to be executed first (for example when
adding new extensions to the resolution process). Silently skipping
such failures allow us to defer the resolution as long as needed
without having any adverse change (since the main entry point won't
resolve anyway if it really can't be resolved at all).
PR-URL: #30336
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 3d4c24d commit 69ec9beCopy full SHA for 69ec9be
File tree
Expand file treeCollapse file tree
4 files changed
+42
-2
lines changedOpen diff view settings
Filter options
- lib/internal/modules/cjs
- test
- fixtures
- sequential
Expand file treeCollapse file tree
4 files changed
+42
-2
lines changedOpen diff view settings
Collapse file
lib/internal/modules/cjs/loader.js
Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js+8-2Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1104 | 1104 | |
1105 | 1105 | |
1106 | 1106 | |
1107 | | - |
| 1107 | + |
| 1108 | + |
| 1109 | + |
| 1110 | + |
| 1111 | + |
| 1112 | + |
| 1113 | + |
1108 | 1114 | |
1109 | 1115 | |
1110 | 1116 | |
1111 | 1117 | |
1112 | 1118 | |
1113 | 1119 | |
1114 | | - |
| 1120 | + |
1115 | 1121 | |
1116 | 1122 | |
1117 | 1123 | |
|
Collapse file
test/fixtures/test-resolution-inspect-brk-main.ext
Copy file name to clipboardExpand all lines: test/fixtures/test-resolution-inspect-brk-main.extWhitespace-only changes.
Collapse file
test/fixtures/test-resolution-inspect-brk-resolver.js
Copy file name to clipboard+5Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
Collapse file
test/sequential/test-resolution-inspect-brk.js
Copy file name to clipboard+29Lines changed: 29 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
0 commit comments