Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 6986154

Browse filesBrowse files
targosdanielleadams
targos
authored and
danielleadams
committed
build: work around bug in MSBuild v16.10.0
This allows to build Node.js at the (temporary) cost of longer build times. Refs: #38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: dotnet/msbuild#6465 Refs: dotnet/msbuild#6373 PR-URL: #38873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 131a691 commit 6986154
Copy full SHA for 6986154

File tree

Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Collapse file

‎vcbuild.bat‎

Copy file name to clipboardExpand all lines: vcbuild.bat
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,8 @@ if "%target%"=="Build" (
334334
if defined cctest set target="Build"
335335
)
336336
if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
337+
@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released.
338+
if "%target%"=="node" set target="Build"
337339
if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
338340
@rem Setup env variables to use multiprocessor build
339341
set UseMultiToolTask=True

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.