Commit 68f698c
src: use SafeGetenv() for NODE_REDIRECT_WARNINGS
Mutations of the environment can invalidate pointers to environment
variables, so make `secure_getenv()` copy them out instead of returning
pointers.
This is the part of #11051 that
applies to be11fb4.
This part wasn't backported to 6.x when #11051 was backported
because the semver-minor introduction
of NODE_REDIRECT_WARNINGS hadn't been backported yet. Now that the
env var is backported, this last bit of #11051 is needed.
PR-URL: #12677
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 16802c0 commit 68f698cCopy full SHA for 68f698c
File tree
Expand file treeCollapse file tree
3 files changed
+8
-8
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
3 files changed
+8
-8
lines changedOpen diff view settings
Collapse file
+3-4Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
207 | 207 | |
208 | 208 | |
209 | 209 | |
210 | | - |
| 210 | + |
211 | 211 | |
212 | 212 | |
213 | 213 | |
| ||
4410 | 4410 | |
4411 | 4411 | |
4412 | 4412 | |
4413 | | - |
4414 | | - |
4415 | | - |
| 4413 | + |
| 4414 | + |
4416 | 4415 | |
4417 | 4416 | |
4418 | 4417 | |
|
Collapse file
+4-3Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
49 | 49 | |
50 | 50 | |
51 | 51 | |
52 | | - |
| 52 | + |
53 | 53 | |
54 | 54 | |
55 | | - |
56 | | - |
| 55 | + |
| 56 | + |
| 57 | + |
57 | 58 | |
58 | 59 | |
59 | 60 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
52 | 52 | |
53 | 53 | |
54 | 54 | |
55 | | - |
| 55 | + |
56 | 56 | |
57 | 57 | |
58 | 58 | |
|
0 commit comments