Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 68db091

Browse filesBrowse files
bnoordhuisMyles Borins
authored andcommitted
src: fix readability/nolint cpplint warnings
PR-URL: #7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
1 parent 4748bed commit 68db091
Copy full SHA for 68db091

File tree

Expand file treeCollapse file tree

2 files changed

+3
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-4
lines changed
Open diff view settings
Collapse file

‎src/node_crypto.cc‎

Copy file name to clipboardExpand all lines: src/node_crypto.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ template void SSLWrap<TLSWrap>::WaitForCertCb(CertCb cb, void* arg);
165165

166166

167167
static void crypto_threadid_cb(CRYPTO_THREADID* tid) {
168-
static_assert(sizeof(uv_thread_t) <= sizeof(void*), // NOLINT(runtime/sizeof)
168+
static_assert(sizeof(uv_thread_t) <= sizeof(void*),
169169
"uv_thread_t does not fit in a pointer");
170170
CRYPTO_THREADID_set_pointer(tid, reinterpret_cast<void*>(uv_thread_self()));
171171
}
Collapse file

‎src/spawn_sync.cc‎

Copy file name to clipboardExpand all lines: src/spawn_sync.cc
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,7 @@ int SyncProcessRunner::CopyJsStringArray(Local<Value> js_value,
973973
data_size = 0;
974974
for (uint32_t i = 0; i < length; i++) {
975975
data_size += StringBytes::StorageSize(isolate, js_array->Get(i), UTF8) + 1;
976-
data_size = ROUND_UP(data_size, sizeof(void*)); // NOLINT(runtime/sizeof)
976+
data_size = ROUND_UP(data_size, sizeof(void*));
977977
}
978978

979979
buffer = new char[list_size + data_size];
@@ -989,8 +989,7 @@ int SyncProcessRunner::CopyJsStringArray(Local<Value> js_value,
989989
js_array->Get(i),
990990
UTF8);
991991
buffer[data_offset++] = '\0';
992-
data_offset = ROUND_UP(data_offset,
993-
sizeof(void*)); // NOLINT(runtime/sizeof)
992+
data_offset = ROUND_UP(data_offset, sizeof(void*));
994993
}
995994

996995
list[length] = nullptr;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.