Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 686587b

Browse filesBrowse files
TrottMylesBorins
authored andcommitted
benchmark: refactor deepequal-set
This is a minor refactor of benchmark/assert/deepequal-set.js to reduce exceptions that need to be made for lint compliance. PR-URL: #21030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 56c6759 commit 686587b
Copy full SHA for 686587b

File tree

Expand file treeCollapse file tree

1 file changed

+16
-17
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+16
-17
lines changed
Open diff view settings
Collapse file

‎benchmark/assert/deepequal-set.js‎

Copy file name to clipboardExpand all lines: benchmark/assert/deepequal-set.js
+16-17Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
'use strict';
22

3-
/* eslint-disable no-restricted-properties */
4-
53
const common = require('../common.js');
6-
const assert = require('assert');
4+
const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
5+
require('assert');
76

87
const bench = common.createBenchmark(main, {
98
n: [5e2],
@@ -48,82 +47,82 @@ function main({ n, len, method }) {
4847
// Empty string falls through to next line as default, mostly for tests.
4948
case 'deepEqual_primitiveOnly':
5049
values = array.map((_, i) => `str_${i}`);
51-
benchmark(assert.deepEqual, n, values);
50+
benchmark(deepEqual, n, values);
5251
break;
5352
case 'deepStrictEqual_primitiveOnly':
5453
values = array.map((_, i) => `str_${i}`);
55-
benchmark(assert.deepStrictEqual, n, values);
54+
benchmark(deepStrictEqual, n, values);
5655
break;
5756
case 'deepEqual_objectOnly':
5857
values = array.map((_, i) => [`str_${i}`, null]);
59-
benchmark(assert.deepEqual, n, values);
58+
benchmark(deepEqual, n, values);
6059
break;
6160
case 'deepStrictEqual_objectOnly':
6261
values = array.map((_, i) => [`str_${i}`, null]);
63-
benchmark(assert.deepStrictEqual, n, values);
62+
benchmark(deepStrictEqual, n, values);
6463
break;
6564
case 'deepEqual_mixed':
6665
values = array.map((_, i) => {
6766
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
6867
});
69-
benchmark(assert.deepEqual, n, values);
68+
benchmark(deepEqual, n, values);
7069
break;
7170
case 'deepStrictEqual_mixed':
7271
values = array.map((_, i) => {
7372
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
7473
});
75-
benchmark(assert.deepStrictEqual, n, values);
74+
benchmark(deepStrictEqual, n, values);
7675
break;
7776
case 'deepEqual_looseMatches':
7877
values = array.map((_, i) => i);
7978
values2 = values.slice().map((v) => String(v));
80-
benchmark(assert.deepEqual, n, values, values2);
79+
benchmark(deepEqual, n, values, values2);
8180
break;
8281
case 'notDeepEqual_primitiveOnly':
8382
values = array.map((_, i) => `str_${i}`);
8483
values2 = values.slice(0);
8584
values2[Math.floor(len / 2)] = 'w00t';
86-
benchmark(assert.notDeepEqual, n, values, values2);
85+
benchmark(notDeepEqual, n, values, values2);
8786
break;
8887
case 'notDeepStrictEqual_primitiveOnly':
8988
values = array.map((_, i) => `str_${i}`);
9089
values2 = values.slice(0);
9190
values2[Math.floor(len / 2)] = 'w00t';
92-
benchmark(assert.notDeepStrictEqual, n, values, values2);
91+
benchmark(notDeepStrictEqual, n, values, values2);
9392
break;
9493
case 'notDeepEqual_objectOnly':
9594
values = array.map((_, i) => [`str_${i}`, null]);
9695
values2 = values.slice(0);
9796
values2[Math.floor(len / 2)] = ['w00t'];
98-
benchmark(assert.notDeepEqual, n, values, values2);
97+
benchmark(notDeepEqual, n, values, values2);
9998
break;
10099
case 'notDeepStrictEqual_objectOnly':
101100
values = array.map((_, i) => [`str_${i}`, null]);
102101
values2 = values.slice(0);
103102
values2[Math.floor(len / 2)] = ['w00t'];
104-
benchmark(assert.notDeepStrictEqual, n, values, values2);
103+
benchmark(notDeepStrictEqual, n, values, values2);
105104
break;
106105
case 'notDeepEqual_mixed':
107106
values = array.map((_, i) => {
108107
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
109108
});
110109
values2 = values.slice();
111110
values2[0] = 'w00t';
112-
benchmark(assert.notDeepEqual, n, values, values2);
111+
benchmark(notDeepEqual, n, values, values2);
113112
break;
114113
case 'notDeepStrictEqual_mixed':
115114
values = array.map((_, i) => {
116115
return i % 2 ? [`str_${i}`, null] : `str_${i}`;
117116
});
118117
values2 = values.slice();
119118
values2[0] = 'w00t';
120-
benchmark(assert.notDeepStrictEqual, n, values, values2);
119+
benchmark(notDeepStrictEqual, n, values, values2);
121120
break;
122121
case 'notDeepEqual_looseMatches':
123122
values = array.map((_, i) => i);
124123
values2 = values.slice().map((v) => String(v));
125124
values2[len - 1] = String(len + 1);
126-
benchmark(assert.notDeepEqual, n, values, values2);
125+
benchmark(notDeepEqual, n, values, values2);
127126
break;
128127
default:
129128
throw new Error(`Unsupported method "${method}"`);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.