Commit 6852461
doc: remove subsystem from pull request template
Remove request that user provide a list of subsystems in the pull
request template.
* We already ask them to put the subsystems in the first line of the
commit message.
* The subsystem is usually easy to determine.
* We have a bot that applies subsystem labels on new PRs and it seems to
do a rather good job. Tools over rules. Let the bot do it.
* The fewer unnecessary things we ask for in the template, the lower the
barrier to entry.
* Anecdotal, but I have never found it useful to have the person
submitting the PR list out subsystems in the pull request post.
PR-URL: #19125
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>1 parent d3a70e9 commit 6852461Copy full SHA for 6852461
File tree
Expand file treeCollapse file tree
1 file changed
+0
-3
lines changedOpen diff view settings
Filter options
- .github
Expand file treeCollapse file tree
1 file changed
+0
-3
lines changedOpen diff view settings
Collapse file
.github/PULL_REQUEST_TEMPLATE.md
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md-3Lines changed: 0 additions & 3 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
14 | 14 | |
15 | 15 | |
16 | 16 | |
17 | | - |
18 | | - |
19 | | - |
0 commit comments