Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 676e618

Browse filesBrowse files
TrottTrott
committed
test: apply correct assert.fail() arguments
The assert.fail function signature has the message as the third argument but, understandably, it is often assumed that it is the first argument (or at least the first argument if no other arguments are passed). This corrects the assert.fail() invocations in the Node.js tests. Before: assert.fail('message'); // result: AssertionError: 'message' undefined undefined After: assert.fail(null, null, 'message'); // result: AssertionError: message PR-URL: #3378 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 0140e1b commit 676e618
Copy full SHA for 676e618
Expand file treeCollapse file tree

13 files changed

+13
-13
lines changed
Open diff view settings
Collapse file

‎test/internet/test-dgram-send-cb-quelches-error.js‎

Copy file name to clipboardExpand all lines: test/internet/test-dgram-send-cb-quelches-error.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function callbackOnly(err) {
2828
}
2929

3030
function onEvent(err) {
31-
assert.fail('Error should not be emitted if there is callback');
31+
assert.fail(null, null, 'Error should not be emitted if there is callback');
3232
}
3333

3434
function onError(err) {
Collapse file

‎test/parallel/test-fs-write-stream.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-fs-write-stream.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ common.refreshTmpDir();
2424
var stream = fs.createWriteStream(file);
2525

2626
stream.on('drain', function() {
27-
assert.fail('\'drain\' event must not be emitted before ' +
27+
assert.fail(null, null, '\'drain\' event must not be emitted before ' +
2828
'stream.write() has been called at least once.');
2929
});
3030
stream.destroy();
Collapse file

‎test/parallel/test-http-header-response-splitting.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-header-response-splitting.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ var server = http.createServer(function(req, res) {
2727
res.writeHead(200, { b: header });
2828
break;
2929
default:
30-
assert.fail('unreachable');
30+
assert.fail(null, null, 'unreachable');
3131
}
3232
res.write(responseBody);
3333
if (testIndex % 8 < 4) {
Collapse file

‎test/parallel/test-http-localaddress-bind-error.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-localaddress-bind-error.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ server.listen(common.PORT, '127.0.0.1', function() {
2424
method: 'GET',
2525
localAddress: invalidLocalAddress
2626
}, function(res) {
27-
assert.fail('unexpectedly got response from server');
27+
assert.fail(null, null, 'unexpectedly got response from server');
2828
}).on('error', function(e) {
2929
console.log('client got error: ' + e.message);
3030
gotError = true;
Collapse file

‎test/parallel/test-https-localaddress-bind-error.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-https-localaddress-bind-error.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ server.listen(common.PORT, '127.0.0.1', function() {
3535
method: 'GET',
3636
localAddress: invalidLocalAddress
3737
}, function(res) {
38-
assert.fail('unexpectedly got response from server');
38+
assert.fail(null, null, 'unexpectedly got response from server');
3939
}).on('error', function(e) {
4040
console.log('client got error: ' + e.message);
4141
gotError = true;
Collapse file

‎test/parallel/test-net-connect-paused-connection.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-connect-paused-connection.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ net.createServer(function(conn) {
1111
net.connect(common.PORT, 'localhost').pause();
1212

1313
setTimeout(function() {
14-
assert.fail('expected to exit');
14+
assert.fail(null, null, 'expected to exit');
1515
}, 1000).unref();
Collapse file

‎test/parallel/test-net-write-slow.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-write-slow.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ var server = net.createServer(function(socket) {
1414
socket.setNoDelay();
1515
socket.setTimeout(1000);
1616
socket.on('timeout', function() {
17-
assert.fail('flushed: ' + flushed +
17+
assert.fail(null, null, 'flushed: ' + flushed +
1818
', received: ' + received + '/' + SIZE * N);
1919
});
2020

Collapse file

‎test/parallel/test-path-parse-format.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-path-parse-format.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ function checkErrors(path) {
8989
return;
9090
}
9191

92-
assert.fail('should have thrown');
92+
assert.fail(null, null, 'should have thrown');
9393
});
9494
}
9595

Collapse file

‎test/parallel/test-repl-reset-event.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-repl-reset-event.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function testResetGlobal(cb) {
4545
}
4646

4747
var timeout = setTimeout(function() {
48-
assert.fail('Timeout, REPL did not emit reset events');
48+
assert.fail(null, null, 'Timeout, REPL did not emit reset events');
4949
}, 5000);
5050

5151
testReset(function() {
Collapse file

‎test/parallel/test-repl.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-repl.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -389,5 +389,5 @@ function unix_test() {
389389
unix_test();
390390

391391
timer = setTimeout(function() {
392-
assert.fail('Timeout');
392+
assert.fail(null, null, 'Timeout');
393393
}, 5000);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.