Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 673c1fd

Browse filesBrowse files
Trottdanielleadams
authored andcommitted
test: avoid using Object.prototype methods directly on objects
This prepares us to enable the no-prototype-builtins ESLint rule. Refs: https://eslint.org/docs/rules/no-prototype-builtins PR-URL: #41801 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
1 parent 4660c1f commit 673c1fd
Copy full SHA for 673c1fd

File tree

Expand file treeCollapse file tree

2 files changed

+5
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-5
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-console-group.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-console-group.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ function teardown() {
151151
// Check that the kGroupIndent symbol property is not enumerable
152152
{
153153
const keys = Reflect.ownKeys(console)
154-
.filter((val) => console.propertyIsEnumerable(val))
154+
.filter((val) => Object.prototype.propertyIsEnumerable.call(console, val))
155155
.map((val) => val.toString());
156156
assert(!keys.includes('Symbol(groupIndent)'),
157157
'groupIndent should not be enumerable');
Collapse file

‎test/parallel/test-stream-base-prototype-accessors-enumerability.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stream-base-prototype-accessors-enumerability.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const { internalBinding } = require('internal/test/binding');
1414
const TTY = internalBinding('tty_wrap').TTY;
1515

1616
{
17-
assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);
18-
assert.strictEqual(TTY.prototype.propertyIsEnumerable('fd'), false);
19-
assert.strictEqual(
20-
TTY.prototype.propertyIsEnumerable('_externalStream'), false);
17+
const ttyIsEnumerable = Object.prototype.propertyIsEnumerable.bind(TTY);
18+
assert.strictEqual(ttyIsEnumerable('bytesRead'), false);
19+
assert.strictEqual(ttyIsEnumerable('fd'), false);
20+
assert.strictEqual(ttyIsEnumerable('_externalStream'), false);
2121
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.