Commit 660ec9f
child_process: refactor self=this in socket_list
The socket list module (used by child_process) currently uses the
`var self = this;` pattern for context in several places, this PR
replaces this with arrow functions or passing a parameter in where
appropriate.
Note that the `var self = this` in the _request is intentioanlly
left in place since it is not trivial to refactor it and the current
pattern isn't bad given the use case.
PR-URL: #5860
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>1 parent 58b5c1e commit 660ec9fCopy full SHA for 660ec9f
File tree
Expand file treeCollapse file tree
1 file changed
+12
-16
lines changedOpen diff view settings
Filter options
- lib/internal
Expand file treeCollapse file tree
1 file changed
+12
-16
lines changedOpen diff view settings
Collapse file
lib/internal/socket_list.js
Copy file name to clipboardExpand all lines: lib/internal/socket_list.js+12-16Lines changed: 12 additions & 16 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
58 | 58 | |
59 | 59 | |
60 | 60 | |
61 | | - |
62 | | - |
63 | 61 | |
64 | 62 | |
65 | 63 | |
66 | 64 | |
67 | | - |
| 65 | + |
68 | 66 | |
69 | 67 | |
70 | 68 | |
| ||
73 | 71 | |
74 | 72 | |
75 | 73 | |
76 | | - |
77 | | - |
| 74 | + |
| 75 | + |
78 | 76 | |
79 | 77 | |
80 | 78 | |
81 | | - |
| 79 | + |
82 | 80 | |
83 | 81 | |
84 | | - |
| 82 | + |
85 | 83 | |
86 | | - |
87 | | - |
| 84 | + |
| 85 | + |
88 | 86 | |
89 | | - |
90 | | - |
| 87 | + |
| 88 | + |
91 | 89 | |
92 | 90 | |
93 | 91 | |
94 | 92 | |
95 | 93 | |
96 | 94 | |
97 | 95 | |
98 | | - |
99 | | - |
100 | 96 | |
101 | 97 | |
102 | 98 | |
103 | | - |
104 | | - |
| 99 | + |
| 100 | + |
105 | 101 | |
106 | | - |
| 102 | + |
107 | 103 | |
108 | 104 | |
0 commit comments