Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 65c136f

Browse filesBrowse files
addaleaxBridgeAR
addaleax
authored and
BridgeAR
committed
worker: partially remove --experimental-worker flag
This is a trimmed-down version of 63d4cae that avoids backporting pain for v11.x. The remainder of the original commit can be cherry-picked later, once other PRs have been backported first. PR-URL: #25404 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> --- Original commit message --- Having an experimental feature behind a flag makes change if we are expecting significant breaking changes to its API. Since the Worker API has been essentially stable since its initial introduction, and no noticeable doubt about possibly not keeping the feature around has been voiced, removing the flag and thereby reducing the barrier to experimentation, and consequently receiving feedback on the implementation, seems like a good idea. Refs: #25361 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 7bb7b9a commit 65c136f
Copy full SHA for 65c136f

File tree

Expand file treeCollapse file tree

53 files changed

+15
-68
lines changed
Open diff view settings
Filter options

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Dismiss banner
Expand file treeCollapse file tree

53 files changed

+15
-68
lines changed
Open diff view settings
Collapse file

‎benchmark/misc/startup.js‎

Copy file name to clipboardExpand all lines: benchmark/misc/startup.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const bench = common.createBenchmark(main, {
1010
script: ['benchmark/fixtures/require-cachable', 'test/fixtures/semicolon'],
1111
mode: ['process', 'worker']
1212
}, {
13-
flags: ['--expose-internals', '--experimental-worker'] // for workers
13+
flags: ['--expose-internals']
1414
});
1515

1616
function spawnProcess(script) {
Collapse file

‎benchmark/worker/echo.js‎

Copy file name to clipboardExpand all lines: benchmark/worker/echo.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
77
payload: ['string', 'object'],
88
sendsPerBroadcast: [1, 10],
99
n: [1e5]
10-
}, { flags: ['--experimental-worker'] });
10+
});
1111

1212
const workerPath = path.resolve(__dirname, '..', 'fixtures', 'echo.worker.js');
1313

Expand file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
-8Lines changed: 0 additions & 8 deletions
  • Display the source diff
  • Display the rich diff
Expand file

‎doc/api/worker_threads.md‎

Copy file name to clipboardExpand all lines: doc/api/worker_threads.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Collapse file

‎doc/node.1‎

Copy file name to clipboardExpand all lines: doc/node.1
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,6 @@ keyword support in REPL.
9494
.It Fl -experimental-vm-modules
9595
Enable experimental ES module support in VM module.
9696
.
97-
.It Fl -experimental-worker
98-
Enable experimental worker threads using worker_threads module.
99-
.
10097
.It Fl -force-fips
10198
Force FIPS-compliant crypto on startup
10299
(Cannot be disabled from script code).
Collapse file

‎test/abort/test-addon-uv-handle-leak.js‎

Copy file name to clipboardExpand all lines: test/abort/test-addon-uv-handle-leak.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ if (process.argv[2] === 'child') {
3636
binding.leakHandle(0x42);
3737
`, { eval: true });
3838
} else {
39-
const child = cp.spawnSync(process.execPath,
40-
['--experimental-worker', __filename, 'child']);
39+
const child = cp.spawnSync(process.execPath, [__filename, 'child']);
4140
const stderr = child.stderr.toString();
4241

4342
assert.strictEqual(child.stdout.toString(), '');
Collapse file

‎test/addons/hello-world/test-worker.js‎

Copy file name to clipboardExpand all lines: test/addons/hello-world/test-worker.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Flags: --experimental-worker
21
'use strict';
32
const common = require('../../common');
43
const assert = require('assert');
Collapse file

‎test/addons/worker-addon/test.js‎

Copy file name to clipboardExpand all lines: test/addons/worker-addon/test.js
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Flags: --experimental-worker
21
'use strict';
32
const common = require('../../common');
43
const assert = require('assert');
@@ -11,7 +10,6 @@ if (process.argv[2] === 'child') {
1110
new Worker(`require(${JSON.stringify(binding)});`, { eval: true });
1211
} else {
1312
const proc = child_process.spawnSync(process.execPath, [
14-
'--experimental-worker',
1513
__filename,
1614
'child'
1715
]);
Collapse file

‎test/parallel/test-async-wrap-missing-method.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-missing-method.js
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// Flags: --experimental-worker
21
'use strict';
32
const common = require('../common');
43
const assert = require('assert');
Collapse file

‎test/parallel/test-heapdump-worker.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-heapdump-worker.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --expose-internals --experimental-worker
1+
// Flags: --expose-internals
22
'use strict';
33
require('../common');
44
const { validateSnapshotNodes } = require('../common/heap');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.