Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 644bfe1

Browse filesBrowse files
santigimenoMyles Borins
authored andcommitted
test: fix test-debug-port-numbers on OS X
According to kill(2), kill returns `EPERM` error if when signalling a process group any of the members could not be signalled. PR-URL: #7046 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 146cba1 commit 644bfe1
Copy full SHA for 644bfe1

File tree

Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-debug-port-numbers.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-debug-port-numbers.js
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ function kill(child) {
4444
try {
4545
process.kill(-child.pid); // Kill process group.
4646
} catch (e) {
47-
assert.strictEqual(e.code, 'ESRCH'); // Already gone.
47+
// Generally ESRCH is returned when the process group is already gone. On
48+
// some platforms such as OS X it may be EPERM though.
49+
assert.ok((e.code === 'EPERM') || (e.code === 'ESRCH'));
4850
}
4951
}
5052

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.