Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 63fbd00

Browse filesBrowse files
cjihrigaddaleax
authored andcommitted
coverage: pass cwd to path.resolve() in setup
During coverage setup, path.resolve() is called. path.resolve() can potentially call process.cwd(), which hasn't been bootstrapped yet. This commit passes the current working directory directly so that path.resolve() doesn't attempt to compute it. PR-URL: #25289 Fixes: #25287 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: #25496
1 parent daca318 commit 63fbd00
Copy full SHA for 63fbd00

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎lib/internal/process/coverage.js‎

Copy file name to clipboardExpand all lines: lib/internal/process/coverage.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ function setup() {
7676
}));
7777

7878
try {
79+
const { cwd } = internalBinding('process_methods');
7980
const { resolve } = require('path');
8081
coverageDirectory = process.env.NODE_V8_COVERAGE =
81-
resolve(process.env.NODE_V8_COVERAGE);
82+
resolve(cwd(), process.env.NODE_V8_COVERAGE);
8283
} catch (err) {
8384
process._rawDebug(err.toString());
8485
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.