Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 62ca2cf

Browse filesBrowse files
Matheus Marchinitargos
authored andcommitted
deps: cherry-pick 70c4340 from upstream V8
Original commit message: [log][api] Fix GCC 4.9 build failure GCC 4.9 used on some Node.js CI machines complains when the control reaches the end of a non-void function and no return is encountered. R=bmeurer@google.com, ofrobots@google.com, yangguo@google.com Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5af0192cb187eccbf34dbb60ff3ac2e4774af803 Reviewed-on: https://chromium-review.googlesource.com/1105619 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53861} Refs: v8/v8@70c4340 PR-URL: #21126 Refs: v8/v8@aa6ce3e Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent ab27e0e commit 62ca2cf
Copy full SHA for 62ca2cf

File tree

Expand file treeCollapse file tree

3 files changed

+9
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+9
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.12',
30+
'v8_embedder_string': '-node.13',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,
Collapse file

‎deps/v8/src/api.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/api.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10255,6 +10255,10 @@ const char* CodeEvent::GetCodeEventTypeName(CodeEventType code_event_type) {
1025510255
CODE_EVENTS_LIST(V)
1025610256
#undef V
1025710257
}
10258+
// The execution should never pass here
10259+
UNREACHABLE();
10260+
// NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9
10261+
return "Unknown";
1025810262
}
1025910263

1026010264
CodeEventHandler::CodeEventHandler(Isolate* isolate) {
Collapse file

‎deps/v8/src/log.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/log.cc
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ static v8::CodeEventType GetCodeEventTypeForTag(
5959
TAGS_LIST(V)
6060
#undef V
6161
}
62+
// The execution should never pass here
63+
UNREACHABLE();
64+
// NOTE(mmarchini): Workaround to fix a compiler failure on GCC 4.9
65+
return v8::CodeEventType::kUnknownType;
6266
}
6367
#define CALL_CODE_EVENT_HANDLER(Call) \
6468
if (listener_) { \

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.