Commit 620ba41
http: don't double-fire the req error event
req.socket._hadError should be set before emitting the error event.
PR-URL: #14659
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent e96b949 commit 620ba41Copy full SHA for 620ba41
File tree
Expand file treeCollapse file tree
2 files changed
+20
-4
lines changedOpen diff view settings
Filter options
- lib
- test/parallel
Expand file treeCollapse file tree
2 files changed
+20
-4
lines changedOpen diff view settings
Collapse file
+4-4Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
373 | 373 | |
374 | 374 | |
375 | 375 | |
376 | | - |
377 | 376 | |
| 377 | + |
378 | 378 | |
379 | 379 | |
380 | 380 | |
| ||
397 | 397 | |
398 | 398 | |
399 | 399 | |
400 | | - |
401 | 400 | |
402 | 401 | |
403 | 402 | |
| 403 | + |
404 | 404 | |
405 | 405 | |
406 | 406 | |
| ||
433 | 433 | |
434 | 434 | |
435 | 435 | |
436 | | - |
437 | 436 | |
| 437 | + |
438 | 438 | |
439 | 439 | |
440 | 440 | |
| ||
455 | 455 | |
456 | 456 | |
457 | 457 | |
458 | | - |
459 | 458 | |
| 459 | + |
460 | 460 | |
461 | 461 | |
462 | 462 | |
|
Collapse file
test/parallel/test-http-client-req-error-dont-double-fire.js
Copy file name to clipboard+16Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
0 commit comments