Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 61ae592

Browse filesBrowse files
conectadotargos
authored andcommitted
test: remove setTimeout in test-net-connect-unref
Removes the setTimeout since if the test were to fail it would time out due to the tools/test.py wrapper PR-URL: #21969 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 254aa83 commit 61ae592
Copy full SHA for 61ae592

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Open diff view settings
Collapse file

‎test/internet/test-net-connect-unref.js‎

Copy file name to clipboardExpand all lines: test/internet/test-net-connect-unref.js
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,8 @@
2323
const common = require('../common');
2424
const net = require('net');
2525

26-
const TIMEOUT = 10 * 1000;
27-
2826
const client = net.createConnection(53, '8.8.8.8', function() {
2927
client.unref();
3028
});
3129

3230
client.on('close', common.mustNotCall());
33-
34-
setTimeout(common.mustNotCall(), TIMEOUT).unref();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.