Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 610297e

Browse filesBrowse files
TrottBethGriggs
authored andcommitted
doc: improve best practices in onboarding-extras
PR-URL: #19315 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent afcf059 commit 610297e
Copy full SHA for 610297e

File tree

Expand file treeCollapse file tree

1 file changed

+3
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+3
-6
lines changed
Open diff view settings
Collapse file

‎doc/onboarding-extras.md‎

Copy file name to clipboardExpand all lines: doc/onboarding-extras.md
+3-6Lines changed: 3 additions & 6 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,7 @@ to update from nodejs/node:
130130
* `git remote update -p` OR `git fetch --all` (I prefer the former)
131131
* `git merge --ff-only upstream/master` (or `REMOTENAME/BRANCH`)
132132

133+
## Best practices
133134

134-
## best practices
135-
136-
* commit often, out to your github fork (origin), open a PR
137-
* when making PRs make sure to spend time on the description:
138-
* every moment you spend writing a good description quarters the amount of time it takes to understand your code.
139-
* usually prefer to only squash at the *end* of your work, depends on the change
135+
* When making PRs, spend time writing a thorough description.
136+
* Usually only squash at the end of your work.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.