Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 60de663

Browse filesBrowse files
legendecasdanielleadams
authored andcommitted
doc: update tags in adding-new-napi-api.md
The tag is now renamed as "node-api". PR-URL: #44190 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
1 parent 9fedf35 commit 60de663
Copy full SHA for 60de663

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎doc/contributing/adding-new-napi-api.md‎

Copy file name to clipboardExpand all lines: doc/contributing/adding-new-napi-api.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Node-API.
1818
ABI compatibility with other versions of Node.js.
1919
* New API **should** be agnostic towards the underlying JavaScript VM.
2020
* New API PRs **must** have a corresponding documentation update.
21-
* New API PRs **must** be tagged as **n-api**.
21+
* New API PRs **must** be tagged as **node-api**.
2222
* There **must** be at least one test case showing how to use the API.
2323
* There **should** be at least one test case per interesting use of the API.
2424
* There **should** be a sample provided that operates in a realistic way
@@ -38,7 +38,7 @@ Node-API.
3838
* Experimental status exit criteria **must** involve at least the
3939
following:
4040
* A new PR **must** be opened in `nodejs/node` to remove experimental
41-
status. This PR **must** be tagged as **n-api** and **semver-minor**.
41+
status. This PR **must** be tagged as **node-api** and **semver-minor**.
4242
* Exiting an API from experimental **must** be signed off by the team.
4343
* If a backport is merited, an API **must** have a down-level
4444
implementation.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.