Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 60b697d

Browse filesBrowse files
zjiazBethGriggs
authored andcommitted
deps: V8: cherry-pick 7889803e82d3
Original commit message: [mips] Use t9 as the function call register. on mips, we should use t9 when jump to a ExternalReference, because the callee function will consider t9 as the function start address. Change-Id: I56e2bf073fd24b2f3434dfd255d48264bfd0b2cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826417 Auto-Submit: Yu Yin <xwafish@gmail.com> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63988} Refs: v8/v8@7889803 PR-URL: #34214 Fixes: #33703 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
1 parent 79c4c73 commit 60b697d
Copy full SHA for 60b697d

File tree

Expand file treeCollapse file tree

3 files changed

+5
-9
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-9
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
# Reset this number to 0 on major V8 upgrades.
3636
# Increment by one for each non-official patch applied to deps/v8.
37-
'v8_embedder_string': '-node.39',
37+
'v8_embedder_string': '-node.40',
3838

3939
##### V8 defaults for Node.js #####
4040

Collapse file

‎deps/v8/src/codegen/mips/macro-assembler-mips.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/mips/macro-assembler-mips.cc
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3853,10 +3853,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
38533853
}
38543854

38553855
void TurboAssembler::Jump(const ExternalReference& reference) {
3856-
UseScratchRegisterScope temps(this);
3857-
Register scratch = temps.Acquire();
3858-
li(scratch, reference);
3859-
Jump(scratch);
3856+
li(t9, reference);
3857+
Jump(t9);
38603858
}
38613859

38623860
void MacroAssembler::JumpIfIsInRange(Register value, unsigned lower_limit,
Collapse file

‎deps/v8/src/codegen/mips64/macro-assembler-mips64.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/codegen/mips64/macro-assembler-mips64.cc
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4202,10 +4202,8 @@ void TurboAssembler::Jump(Handle<Code> code, RelocInfo::Mode rmode,
42024202
}
42034203

42044204
void TurboAssembler::Jump(const ExternalReference& reference) {
4205-
UseScratchRegisterScope temps(this);
4206-
Register scratch = temps.Acquire();
4207-
li(scratch, reference);
4208-
Jump(scratch);
4205+
li(t9, reference);
4206+
Jump(t9);
42094207
}
42104208

42114209
// Note: To call gcc-compiled C code on mips, you must call through t9.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.