Commit 60296a3
lib: make tick processor detect xcodebuild errors
`node --prof-process` on macOS calls out to nm(1) to look up C++
symbols. If Xcode hasn't been properly installed or its license
hasn't been accepted yet, it prints out an error and exits.
Before this commit, that error was swallowed and the output of
the tick processor was not showing the C++ entry points.
This commit detects that error message and turns it into an
exception. No regression test because this particular condition
is hard to test for without going to extreme lengths to mock
the output of nm.
Fixes: #29804
PR-URL: #29830
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 600478a commit 60296a3Copy full SHA for 60296a3
File tree
Expand file treeCollapse file tree
1 file changed
+8
-1
lines changedOpen diff view settings
Filter options
- lib/internal
Expand file treeCollapse file tree
1 file changed
+8
-1
lines changedOpen diff view settings
Collapse file
lib/internal/v8_prof_polyfill.js
Copy file name to clipboardExpand all lines: lib/internal/v8_prof_polyfill.js+8-1Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
48 | 48 | |
49 | 49 | |
50 | 50 | |
51 | | - |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
52 | 58 | |
| 59 | + |
53 | 60 | |
54 | 61 | |
55 | 62 | |
|
0 commit comments