Commit 5fe7741
committed
src: dispose of V8 platform in
Calling `process.exit()` calls the C `exit()` function, which in turn
calls the destructors of static C++ objects. This can lead to race
conditions with other concurrently executing threads; disposing of all
Worker threads and then the V8 platform instance helps with this
(although it might not be a full solution for all problems of
this kind).
Refs: #24403
Refs: #25007
PR-URL: #25061
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>process.exit()
1 parent b67c4b4 commit 5fe7741Copy full SHA for 5fe7741
File tree
Expand file treeCollapse file tree
3 files changed
+10
-2
lines changedOpen diff view settings
Filter options
- src
Expand file treeCollapse file tree
3 files changed
+10
-2
lines changedOpen diff view settings
Collapse file
+5-2Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
862 | 862 | |
863 | 863 | |
864 | 864 | |
865 | | - |
| 865 | + |
| 866 | + |
| 867 | + |
866 | 868 | |
867 | | - |
| 869 | + |
868 | 870 | |
| 871 | + |
869 | 872 | |
870 | 873 | |
871 | 874 | |
|
Collapse file
+4Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
337 | 337 | |
338 | 338 | |
339 | 339 | |
| 340 | + |
| 341 | + |
| 342 | + |
| 343 | + |
340 | 344 | |
341 | 345 | |
342 | 346 | |
|
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
358 | 358 | |
359 | 359 | |
360 | 360 | |
| 361 | + |
361 | 362 | |
362 | 363 | |
363 | 364 | |
|
0 commit comments