Commit 5fb7a0b
deps: fix addons compilation with VS2013
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.
Fixes: nodejs/node-v8#4
PR-URL: #13263
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent ad928c0 commit 5fb7a0bCopy full SHA for 5fb7a0b
Expand file treeCollapse file tree
2 files changed
+23
-4
lines changedOpen diff view settings
Collapse file
+8-4Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4025 | 4025 | |
4026 | 4026 | |
4027 | 4027 | |
4028 | | - |
| 4028 | + |
| 4029 | + |
| 4030 | + |
4029 | 4031 | |
4030 | 4032 | |
4031 | | - |
| 4033 | + |
4032 | 4034 | |
4033 | 4035 | |
4034 | 4036 | |
| ||
4101 | 4103 | |
4102 | 4104 | |
4103 | 4105 | |
4104 | | - |
| 4106 | + |
| 4107 | + |
| 4108 | + |
4105 | 4109 | |
4106 | | - |
| 4110 | + |
4107 | 4111 | |
4108 | 4112 | |
4109 | 4113 | |
|
Collapse file
+15Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7592 | 7592 | |
7593 | 7593 | |
7594 | 7594 | |
| 7595 | + |
| 7596 | + |
| 7597 | + |
| 7598 | + |
| 7599 | + |
| 7600 | + |
| 7601 | + |
| 7602 | + |
7595 | 7603 | |
7596 | 7604 | |
7597 | 7605 | |
| ||
7706 | 7714 | |
7707 | 7715 | |
7708 | 7716 | |
| 7717 | + |
| 7718 | + |
| 7719 | + |
| 7720 | + |
| 7721 | + |
| 7722 | + |
| 7723 | + |
7709 | 7724 | |
7710 | 7725 | |
7711 | 7726 | |
|
0 commit comments