Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5f07f49

Browse filesBrowse files
cjihrigtargos
authored andcommitted
doc: revoke DEP0089
Using the legacy assert module is not discouraged. Revoke DEP0089 to avoid user confusion. PR-URL: #28892 Fixes: #28780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent d72b682 commit 5f07f49
Copy full SHA for 5f07f49

File tree

Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+7-4Lines changed: 7 additions & 4 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1780,18 +1780,21 @@ cause a lot of issues. See <https://github.com/nodejs/node/issues/14328>.
17801780
### DEP0089: require('assert')
17811781
<!-- YAML
17821782
changes:
1783+
- version: REPLACEME
1784+
pr-url: https://github.com/nodejs/node/pull/28892
1785+
description: Deprecation revoked.
17831786
- version:
17841787
- v9.9.0
17851788
- v10.0.0
17861789
pr-url: https://github.com/nodejs/node/pull/17002
17871790
description: Documentation-only deprecation.
17881791
-->
17891792
1790-
Type: Documentation-only
1793+
Type: Deprecation revoked
17911794
1792-
Importing assert directly is not recommended as the exposed functions will use
1793-
loose equality checks. Use `require('assert').strict` instead. The API is the
1794-
same as the legacy assert but it will always use strict equality checks.
1795+
Importing assert directly was not recommended as the exposed functions use
1796+
loose equality checks. The deprecation was revoked because use of the `assert`
1797+
module is not discouraged, and the deprecation caused end user confusion.
17951798
17961799
<a id="DEP0090"></a>
17971800
### DEP0090: Invalid GCM authentication tag lengths

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.