Commit 5e5af8b
benchmark: fix child-process-read on Windows
Under Windows 'ipc' communication requires the other process to format
its messages with 'IPC framing protocol'. Otherwise, an assert is
triggered in libuv. This commit changes child-process-read benchmark
to use stdout to communicate with parent process. It also adds
child-process-read-ipc.js to benchmark IPC communication using
child node process.
PR-URL: #6971
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 0fc8012 commit 5e5af8bCopy full SHA for 5e5af8b
File tree
Expand file treeCollapse file tree
2 files changed
+47
-3
lines changedOpen diff view settings
Filter options
- benchmark/child_process
Expand file treeCollapse file tree
2 files changed
+47
-3
lines changedOpen diff view settings
Collapse file
benchmark/child_process/child-process-read-ipc.js
Copy file name to clipboard+37Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
Collapse file
benchmark/child_process/child-process-read.js
Copy file name to clipboardExpand all lines: benchmark/child_process/child-process-read.js+10-3Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
3 | 10 | |
4 | | - |
| 11 | + |
5 | 12 | |
6 | 13 | |
7 | 14 | |
| ||
13 | 20 | |
14 | 21 | |
15 | 22 | |
16 | | - |
| 23 | + |
17 | 24 | |
18 | 25 | |
19 | 26 | |
20 | | - |
| 27 | + |
21 | 28 | |
22 | 29 | |
23 | 30 | |
|
0 commit comments